Forward Port of #36773 to saas-12.3 #36784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we would try to decode the logo of a company without any verification on its presence. If the logo was not set, we'd try to decode nothing which caused a crash. This commit ensure that we asert that the field is set before trying to encode it for a JSON payload. X-original-commit: f40f763
|
This PR targets saas-12.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
This forward port PR is awaiting action |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Sep 13, 2019
Prior to this commit, we would try to decode the logo of a company without any verification on its presence. If the logo was not set, we'd try to decode nothing which caused a crash. This commit ensure that we asert that the field is set before trying to encode it for a JSON payload. closes #36784 X-original-commit: f40f763 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 13, 2019
Prior to this commit, we would try to decode the logo of a company without any verification on its presence. If the logo was not set, we'd try to decode nothing which caused a crash. This commit ensure that we asert that the field is set before trying to encode it for a JSON payload. closes #36784 X-original-commit: f40f763 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
|
Merged at 3f401e3, thanks! |
fw-bot
deleted the
saas-12.3-12.0-fix-snailmail-logo-rar-ZG5TL6FQ-forwardport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] snailmail: do not decode null objects
Prior to this commit, we would try to decode the logo of a company
without any verification on its presence. If the logo was not set, we'd
try to decode nothing which caused a crash.
This commit ensure that we asert that the field is set before trying to
encode it for a JSON payload.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #36773