[FIX] models: using unknown fields makes CRUD methods crash #37094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rco-odoo
force-pushed
the
saas-12.5-unknown-fields-rco
branch
2 times, most recently
from
d1004cc
to
69a2a8b
Compare
robodoo
added
CI 🤖
rco-odoo
force-pushed
the
saas-12.5-unknown-fields-rco
branch
from
127a397
to
78c871d
Compare
robodoo
added
CI 🤖
The basic ORM methods should not silently discard unknown fields, as they may be a sign of broken code.
rco-odoo
force-pushed
the
saas-12.5-unknown-fields-rco
branch
from
78c871d
to
4bcb6c1
Compare
robodoo
added
CI 🤖
odony
reviewed
Oct 22, 2019
| @@ -100,7 +99,6 @@ def _check_holidays_status(holiday_status, ml, lt, rl, vrl): | |||
| HolidayStatusManagerGroup.create({ | |||
| 'name': 'WithMeetingType', | |||
| 'allocation_type': 'no', | |||
| 'categ_id': self.env['calendar.event.type'].with_user(self.user_hrmanager_id).create({'name': 'NotLimitedMeetingType'}).id, | |||
odony
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
Cool, this will make the behavior uniform for all cases, and definitely catch mistakes and typos earlier. Not much of a semantic change for 13.0 either, as the refactored ORM already blocked read() on non-existant fields.
@robodoo rebase-ff r+
|
Merge method set to rebase and fast-forward |
|
Merged at 9492b01, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic ORM methods should not silently discard unknown fields, as
they may be a sign of broken code.