[FIX] multicompany support on hr models #39057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvasquez13
changed the title
|
Hi, Thank you for your PR but please check our stable policy. In 12.0, only bug fixes should land and you can not add or remove new files. Please check the master version, if some improvements are still needed, please resubmit there and I am sure @tivisse will review them. Also, try to keep your pull request to the minimum, don't try to make too many things. For instance, I see you are changing translation files, it should be on transifex, not github. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Fix hr models to work with multicompany
Current behavior before PR:
HR's models only work with one company
Desired behavior after PR is merged:
HR's models must work with many companies