[FIX] models.py: update parent_path on unlink

[nle-odoo]

opw-2148046

[nle-odoo]

there has been some version of this commit:

diff --git a/odoo/models.py b/odoo/models.py
index cf01b31a65b17..0b7e67c5bed55 100644
--- a/odoo/models.py
+++ b/odoo/models.py
@@ -3301,6 +3301,11 @@ def unlink(self):
         if self.env['ir.property'].search([('res_id', '=', False), ('value_reference', 'in', refs)]):
             raise UserError(_('Unable to delete this document because it is used as a default property'))
 
+        # determine records that require updating parent_path
+        child_records = self.browse()
+        if self._parent_store:
+            child_records = self.search([(self._parent_name, 'child_of', self.ids)]) - self
+
         # Delete the records' properties.
         with self.env.norecompute():
             self.check_access_rule('unlink')
@@ -3349,6 +3354,10 @@ def unlink(self):
                 if attachments:
                     ir_attachment_unlink |= attachments.sudo()
 
+            # update parent_path
+            if child_records:
+                child_records._parent_store_update()
+
             # invalidate the *whole* cache, since the orm does not handle all
             # changes made in the database, like cascading delete!
             self.invalidate_cache()

and

diff --git a/odoo/models.py b/odoo/models.py
index cf01b31a65b17..b0dd16b1c598e 100644
--- a/odoo/models.py
+++ b/odoo/models.py
@@ -3301,6 +3301,10 @@ def unlink(self):
         if self.env['ir.property'].search([('res_id', '=', False), ('value_reference', 'in', refs)]):
             raise UserError(_('Unable to delete this document because it is used as a default property'))
 
+        # update child records return_path
+        if self._parent_store and self._fields[self._parent_name].ondelete == 'set null':
+            self.search([(self._parent_name, '=', self.ids)])[self._parent_name] = None
+
         # Delete the records' properties.
         with self.env.norecompute():
             self.check_access_rule('unlink')

but these solutions still have an issue in the case of deletion of records through a ondelete="cascade", so the simplest solution seems to be:

• for v13 explicitly remove parents from child nodes (then the orm write will do what's needed)

• for master: set ondelete="cascade" on the field parent_id of product.public.category (this will be adapted in forward-port)

robodoo r+

[nle-odoo]

robodoo r+

[fmdl]

@rco-odoo it an exemple of the isssue with the SQL cascade.

#33113

regards