Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][IMP] account: added method for processing extra fields in refund wizard #41495

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Dec 6, 2019

If we add an extra field in the refund wizard, e.g.
there was no good method to inherit in order to put it on
the refund before the refund was posted in case of the
cancel or modify case.

That is why we put this code in a separate method, so
we can still modify the refund with the information from
the wizard before being posted. (as it is e.g. sent through
the api when posted)

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #41478

If we add an extra field in the refund wizard, e.g.
there was no good method to inherit in order to put it on
the refund before the refund was posted in case of the
cancel or modify case.

That is why we put this code in a separate method, so
we can still modify the refund with the information from
the wizard before being posted.  (as it is e.g. sent through
the api when posted)

X-original-commit: 26c3eb0
@fw-bot
Copy link
Contributor Author

fw-bot commented Dec 6, 2019

Ping @jco-odoo, @qdp-odoo
Cherrypicking f01b840 of source #41478 failed

stderr:

error: could not apply f01b8403017... [REF] account: added method for processing extra fields in refund wizard
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@robodoo robodoo added conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot labels Dec 6, 2019
@jco-odoo
Copy link
Contributor

jco-odoo commented Dec 6, 2019

@nla-odoo Can you check if we can at least update this for 12.3. It will work differently for later versions anyways.

@C3POdoo C3POdoo added the RD research & development, internal work label Dec 6, 2019
@qdp-odoo
Copy link
Contributor

@jco-odoo can you do something with that PR? It bugs me

@jco-odoo
Copy link
Contributor

jco-odoo commented Dec 19, 2019

@qdp-odoo @nla-odoo We will need some time to do it, so I will close it for the moment. You can always take the branch again and do the fixes and create another PR. There should not be too many things to do. But there are for 13.0 and that is the primary focus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants