[IMP] base: prevent focus on search input in settings #42661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dharmrajsinh-jhala
force-pushed
the
master-settings-ui-akt
branch
from
495503a
to
02f3815
Compare
dharmrajsinh-jhala
force-pushed
the
master-settings-ui-akt
branch
from
02f3815
to
8d36e34
Compare
robodoo
added
CI 🤖
adr-odoo
force-pushed
the
master-settings-ui-akt
branch
from
8d36e34
to
ea94804
Compare
adr-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 16, 2020
Previously when we opened settings, the foucs jumped to the search input. For better usability, this commit prevents from happening so in mobile devices. TaskID: 2150992 Closes: odoo#42661
adr-odoo
force-pushed
the
master-settings-ui-akt
branch
from
ea94804
to
7f2256b
Compare
adr-odoo
force-pushed
the
master-settings-ui-akt
branch
from
7f2256b
to
f833cf7
Compare
robodoo
added
CI 🤖
adr-odoo
force-pushed
the
master-settings-ui-akt
branch
from
f833cf7
to
392e5b0
Compare
robodoo
added
CI 🤖
adr-odoo
force-pushed
the
master-settings-ui-akt
branch
from
392e5b0
to
be67bb2
Compare
robodoo
added
CI 🤖
adr-odoo
force-pushed
the
master-settings-ui-akt
branch
from
be67bb2
to
19fc5f9
Compare
Previously when we opened settings, the foucs jumped to the search input. For better usability, this commit prevents from happening so in mobile devices. TaskID: 2150992 Closes: odoo#42661
adr-odoo
force-pushed
the
master-settings-ui-akt
branch
from
19fc5f9
to
e916e41
Compare
adr-odoo
force-pushed
the
master-settings-ui-akt
branch
from
4b00dee
to
ac33b4d
Compare
The previous style defined on the latter removed the padding which breaks the style when several buttons follow each other. This commit should fix the style while maintaining the intended behaviour, a vertical alignment between the button and the text inside the pane.
adr-odoo
force-pushed
the
master-settings-ui-akt
branch
from
ac33b4d
to
67ab4b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task : https://www.odoo.com/web#id=2150992&action=333&active_id=1520&model=project.task&view_type=form&menu_id=4720
Pad : https://pad.odoo.com/p/r.62f98fc53c42e62af074c7307ebb7894
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr