Staging merge #43127
Closed
Staging merge #43127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tde-banana-odoo
force-pushed
the
master-staging-13.2-tde
branch
from
cc82b7b
to
42ac03f
Compare
PURPOSE As event will soon evolve (onchange -> compute, code improvements, addition of new features) cleaning and improving tests is necessary to help avoid issues. SPECIFICATIONS Clean existing tests: lessen data / variables, try to remove unnecessary tests or merge duplicates. Add new tests, notably event type configuration copy onto event records is not well tested. Event computed fields are also more tested. Some access tests are added, more a base for future addition as only a few use cases are covered. LINKS Side effect of Task ID 2089156 (event onchange to compute) Community PR odoo#43127 Enterprise PR odoo/enterprise#7656
Currently event_count is a computed field with a shortcut in computation for non event user. It is better to directly limit this field to the event_user group instead. LINKS Side effect of Task ID 2089156 (event onchange to compute) Community PR odoo#43127 Enterprise PR odoo/enterprise#7656
tde-banana-odoo
force-pushed
the
master-staging-13.2-tde
branch
from
42ac03f
to
fb3b85b
Compare
tde-banana-odoo
force-pushed
the
master-staging-13.2-tde
branch
from
fb3b85b
to
e86a0d4
Compare
tde-banana-odoo
force-pushed
the
master-staging-13.2-tde
branch
from
8df4e36
to
4fbdc5a
Compare
tde-banana-odoo
force-pushed
the
master-staging-13.2-tde
branch
from
4fbdc5a
to
e864b16
Compare
tde-banana-odoo
force-pushed
the
master-staging-13.2-tde
branch
from
e864b16
to
437f032
Compare
PURPOSE As event will soon evolve (onchange -> compute, code improvements, addition of new features) cleaning and improving tests is necessary to help avoid issues. SPECIFICATIONS As event model grow in complexity and features, it is easier to find its way through the application with having registration model lying in its own file to separate it from event-specific models (event.type, event.event). Ticket (event_sale) and sponsor (website_event_track) models are also extracted in their own file. LINKS LINKS Side effect of Task ID 2089156 (event onchange to compute) Community PR odoo#43127 Enterprise PR odoo/enterprise#7656
PURPOSE As event will soon evolve (onchange -> compute, code improvements, addition of new features) cleaning and improving tests is necessary to help avoid issues. SPECIFICATIONS Use _tz_get for tz-based selection fields from partner as it smartly order available timezones. Remove a strange "event.confirm" wizard that calls an unexisting method, is not reachable and is actually completely unnecessary. Reorganize ticket fields to ease future improvements and perform some public -> private method cleaning. Remove duplicated code in event_sale. LINKS Side effect of Task ID 2089156 (event onchange to compute) Community PR odoo#43127 Enterprise PR odoo/enterprise#7656 prout
PURPOSE As crm will soon evolve (onchange -> compute, code improvements, addition of new features) cleaning and improving tests is necessary to help avoid issues. SPECIFICATIONS In this commit we add tests for the lead 2 opportunity converters. Indeed it is strange that such a critical wizard has so few tests. Notably the use of single-lead / multi-lead mode is more tested, allowing to see that code is somewhat oldish. LINKS Side effect of Task ID 2056759 (remove crm.partner.binding mixin) Side effect of Task ID 2088565 (crm onchange -> compute) Community PR odoo#43127 Enterprise PR odoo/enterprise#7656
Lead 2 opportunity wizard file actually holds 2 wizards. Let us split files especially that naming is quite obfuscated. LINKS Side effect of Task ID 2056759 (remove crm.partner.binding mixin) Side effect of Task ID 2088565 (crm onchange -> compute) Community PR odoo#43127 Enterprise PR odoo/enterprise#7656
Try to understand a bit this code with comments. Some unnecessary code is removed, and some parameters are added to try to understand the various flows, but main purpose is to understand that mighty spaghetti, not destroy it. LINKS Side effect of Task ID 2056759 (remove crm.partner.binding mixin) Side effect of Task ID 2088565 (crm onchange -> compute) Community PR odoo#43127 Enterprise PR odoo/enterpreise#7656
tde-banana-odoo
force-pushed
the
master-staging-13.2-tde
branch
from
437f032
to
bdfedfa
Compare
|
@robodoo r+ rebase-ff |
tde-banana-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 17, 2020
…wizards PURPOSE As crm will soon evolve (onchange -> compute, code improvements, better management of sales teams) cleaning and improving tests is necessary to avoid regressions. SPECIFICATIONS After ff6b35f that added some first tests, this commit will add more tests notably about convert wizards. Notably * add tests for crm.lead2opportunity.partner wizard, notably options about action (do nothing, exist or create partner), as well as some corner cases like stage update, lost leads, ... * rewrite and improve tests about crm.lead2opportunity.partner.mass, aka the mass converted wizard that implements some random behavior on top of the crm.lead2opportunity.partner wizard; Some strange behaviors spotted * partner action works on lost leads, but not the convert; * user_id / team_id / stage_id coherency is not enforced during convert as it relies mainly on onchanges that are not called; LINKS Task ID 2056759 (remove crm.partner.binding mixin) Task ID 2088565 (crm onchange -> compute) Community PR odoo#43127 Enterprise PR odoo/enterprise#7322
tde-banana-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 17, 2020
PURPOSE
As crm will soon evolve (onchange -> compute, code improvements, better
management of sales teams) cleaning and improving tests is necessary to avoid
regressions.
SPECIFICATIONS
Improve and clean tests about leads and opportunities merge.
Some strange behaviors spotted
* user_id / team_id interaction is somehow unclear;
* probability is not taken into account in confidence level, which is very
very strange;
LINKS
Task ID 2056759 (remove crm.partner.binding mixin)
Task ID 2088565 (crm onchange -> compute)
Community PR odoo#43127
Enterprise PR odoo/enterprise#7322
tde-banana-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 17, 2020
…ration when contacting a visitor Purpose of this commit is to clean mail composer calls by separating context computation from record update. Indeed most of composer code is based on records having a partner_id correctly set, unless some templates are used that dynamically create the partner. In this commit we move the partner assignation on lead and its visitor outside of the composer context computation, to better understand what is done. LINKS Task ID 2056759 (remove crm.partner.binding mixin) Task ID 2088565 (crm onchange -> compute) Community PR odoo#43127 Enterprise PR odoo/enterprise#7322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.