Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] stock_dropshipping: correct dependencies #43252

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Jan 14, 2020

purchase_stock is a required dependencies because the stock.rule
stock_rule_drop_shipping use buy as action [1].
However, it is added to the selection by the module purchase_stock [2].

[1]

<field name="action">buy</field>

[2]
action = fields.Selection(selection_add=[('buy', 'Buy')])

Forward-Port-Of: #43218

`purchase_stock` is a required dependencies because the `stock.rule`
`stock_rule_drop_shipping` use `buy` as `action` [1].
However, it is added to the selection by the module `purchase_stock` [2].

[1] https://github.com/odoo/odoo/blob/c4b6273c9df5d8e3f3a5ee3cf52541741526280e/addons/stock_dropshipping/data/stock_data.xml#L32
[2] https://github.com/odoo/odoo/blob/c4b6273c9df5d8e3f3a5ee3cf52541741526280e/addons/purchase_stock/models/stock_rule.py#L14

X-original-commit: eab5bc5
@fw-bot
Copy link
Contributor Author

fw-bot commented Jan 14, 2020

This PR targets saas-13.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added seen 🙂 forwardport This PR was created by @fw-bot CI 🤖 Robodoo has seen passing statuses labels Jan 14, 2020
@C3POdoo C3POdoo added the RD research & development, internal work label Jan 14, 2020
robodoo pushed a commit that referenced this pull request Jan 14, 2020
`purchase_stock` is a required dependencies because the `stock.rule`
`stock_rule_drop_shipping` use `buy` as `action` [1].
However, it is added to the selection by the module `purchase_stock` [2].

[1] https://github.com/odoo/odoo/blob/c4b6273c9df5d8e3f3a5ee3cf52541741526280e/addons/stock_dropshipping/data/stock_data.xml#L32
[2] https://github.com/odoo/odoo/blob/c4b6273c9df5d8e3f3a5ee3cf52541741526280e/addons/purchase_stock/models/stock_rule.py#L14

closes #43252

X-original-commit: eab5bc5
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
@robodoo robodoo closed this Jan 14, 2020
@robodoo robodoo temporarily deployed to merge January 14, 2020 10:10 Inactive
@fw-bot fw-bot deleted the saas-13.1-12.0-dropshipping-deps-chs-16G--fw branch January 28, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants