[FW][FIX] base: search user by name negatively #44146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we name_search a res.user, we have a special hack so we will firstly perform an exact search on the res.users login, if none is found we will search over res.users name. This is intended but in the case of negative search since 660cebb, for example operator='not ilike' and name='test' would probably just return all user that do not have a login that is exactly test. This is not the intended behavior, in this instance we should just return user that do not have "test" in their names. Without fix, added test would fail on: - .name_search('vlad', operator='not ilike') => finding everyone but user with exactly login vlad instead of user not containing vlad in their name - .name_search('', operator='not ilike') => find all users instead of finding no user - .name_search('lad', operator='not ilike') => find all users instead of just finding "Nothing similar" opw-2170517 closes odoo#44040 X-original-commit: 2378fb6
|
This PR targets saas-12.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Jan 29, 2020
When we name_search a res.user, we have a special hack so we will firstly perform an exact search on the res.users login, if none is found we will search over res.users name. This is intended but in the case of negative search since 660cebb, for example operator='not ilike' and name='test' would probably just return all user that do not have a login that is exactly test. This is not the intended behavior, in this instance we should just return user that do not have "test" in their names. Without fix, added test would fail on: - .name_search('vlad', operator='not ilike') => finding everyone but user with exactly login vlad instead of user not containing vlad in their name - .name_search('', operator='not ilike') => find all users instead of finding no user - .name_search('lad', operator='not ilike') => find all users instead of just finding "Nothing similar" opw-2170517 closes #44040 closes #44146 X-original-commit: 2378fb6 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we name_search a res.user, we have a special hack so we will
firstly perform an exact search on the res.users login, if none is found
we will search over res.users name.
This is intended but in the case of negative search since 660cebb,
for example operator='not ilike' and name='test' would probably just
return all user that do not have a login that is exactly test.
This is not the intended behavior, in this instance we should just
return user that do not have "test" in their names.
Without fix, added test would fail on:
.name_search('vlad', operator='not ilike') => finding everyone but
user with exactly login vlad instead of user not containing vlad in
their name
.name_search('', operator='not ilike') => find all users instead of
finding no user
opw-2170517
Forward-Port-Of: #44040