[FIX] product: removal of hardcoded value in product template #44649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: - install sales - activate units of measures and variants - set imperial units under general settings (pounds for weight and ft³ for volume) - create at least 2 variants on a product and access them via the smart button from product.template Previous behavior: the volume remains in m³, it is hardcoded in the template Current behavior: the volume is printed just like the weight (generic uom notation) opw-2186965
jhk-odoo
force-pushed
the
13.0-opw-2186965-valome_metric_hardcoded_in_template-jhk
branch
from
fec6d04
to
6cf1878
Compare
jpp-odoo
approved these changes
Feb 5, 2020
This was referenced Feb 6, 2020
fw-bot
deleted the
13.0-opw-2186965-valome_metric_hardcoded_in_template-jhk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
from product.template
Previous behavior:
the volume remains in m³, it is hardcoded in the template
Current behavior:
the volume is printed just like the weight (generic uom notation)
opw-2186965