Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web_editor: some v13 fixes from task 2115528 #44691

Closed
wants to merge 4 commits into from

Conversation

Gorash
Copy link
Contributor

@Gorash Gorash commented Feb 6, 2020

opw-2115528

@Gorash Gorash requested review from sbuhl and dmo-odoo February 6, 2020 09:20
@robodoo robodoo added seen 🙂 CI 🤖 Robodoo has seen passing statuses labels Feb 6, 2020
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Feb 6, 2020
Copy link

@sbuhl sbuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Gorash
Can you describe what you've done?
All the points from the pad on task 2115528?

@Gorash
Copy link
Contributor Author

Gorash commented Feb 6, 2020

@sbuhl no, some fixe/improvement. See the picture link in the task.

[FIX] web_editor: color-picker: see selected color below toolbar button
[FIX] web_editor: can change/add an icon/image in a button
[IMP] web_editor: allow the user to choose a custom font size
[FIX] web_editor: add a button/icon to add custom color in colorpicker

@sbuhl
Copy link

sbuhl commented Feb 6, 2020

@Gorash Sorry, I'm tired, didn't see the commits...
For [IMP] web_editor: allow the user to choose a custom font size, I'd rather do in master.

cc: @qsm-odoo @JKE-be

@dmo-odoo dmo-odoo changed the title some fixes for web_editor [FIX] web_editor: some v13 fixes from task 2115528 Feb 25, 2020
@dmo-odoo
Copy link
Contributor

dmo-odoo commented Feb 25, 2020

@Gorash:

  • "color-picker: see selected color below toolbar button": It works for the font color button, but not for the font background color one. I would expect both buttons to work in the same way.
  • "can change/add an icon/image in a button": I don't understand the code this commit introduces because I am not familiar with summernote, so I am unable to review it properly.
  • "allow the user to choose a custom font size": I agree with @sbuhl that this should be done in master.
  • "add a button/icon to add custom color in colorpicker": this one is fine by me.

cc @qsm-odoo @JKE-be

@qsm-odoo
Copy link
Contributor

@sbuhl I am closing this PR. If necessary you can mention it in a master task, but this would probably be about master work for the editor team in a few months anyway..?

  • "Colorpicker selected color": already fixed in 13.0 and working in 14.0 too
  • "can change/add an icon/image in a button": seems to already work on my side for changing and for the ability to add, it should be a master task IMO
  • "allow the user to choose a custom font size": master for sure
  • "add a button/icon to add custom color in colorpicker": the UI is bad in 13.0 but working. Not worth the risk breaking custo while fixing it, especially since it is nice in 14.0.

Anybody feel free to reopen and merge if I am wrong 👍

@qsm-odoo qsm-odoo closed this Jan 12, 2021
@Gorash Gorash deleted the 13.0-fix-editor-chm branch May 19, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants