[IMP] ir_mail_server: IDNA and SMTPUTF8 capabilities #47709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julien00859
force-pushed
the
master-2116928-idna_email_address-juc
branch
from
e14f2d9
to
401737d
Compare
Julien00859
force-pushed
the
master-2116928-idna_email_address-juc
branch
2 times, most recently
from
bda0179
to
652442b
Compare
|
Related opw: |
It has been a recurrent request from customers to be able to send email messages to email addresses containing non-ascii characters. [IDNA] is a domain extension to allow unicode characters in domain names. [SMTPUTF8] is a SMTP extension to allow unicode in any header. IDNA defines the [punycode] encoding which translates unicode to an ascii representation. This encoding MUST be used to encode domains. SMTPUTF8 is an SMTP extension that allow utf-8 in all headers on the envelope. [IDNA] https://tools.ietf.org/html/rfc5890 [SMTPUTF8] https://tools.ietf.org/html/rfc6531 [punycode] https://tools.ietf.org/html/rfc3492 Task: 2116928 opw-2229906 opw-2248251
Julien00859
force-pushed
the
master-2116928-idna_email_address-juc
branch
from
652442b
to
f41ddb8
Compare
rco-odoo
approved these changes
May 5, 2020
robodoo
pushed a commit
that referenced
this pull request
May 5, 2020
It has been a recurrent request from customers to be able to send email messages to email addresses containing non-ascii characters. [IDNA] is a domain extension to allow unicode characters in domain names. [SMTPUTF8] is a SMTP extension to allow unicode in any header. IDNA defines the [punycode] encoding which translates unicode to an ascii representation. This encoding MUST be used to encode domains. SMTPUTF8 is an SMTP extension that allow utf-8 in all headers on the envelope. [IDNA] https://tools.ietf.org/html/rfc5890 [SMTPUTF8] https://tools.ietf.org/html/rfc6531 [punycode] https://tools.ietf.org/html/rfc3492 Task: 2116928 opw-2229906 opw-2248251 closes #47709 Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
| @@ -25,16 +25,6 @@ def test_mail_message_notify_from_mail_mail(self): | |||
| self.assertSentEmail(mail.env.user.partner_id, ['test@example.com']) | |||
| self.assertEqual(len(self._mails), 1) | |||
|
|
|||
| @mute_logger('odoo.addons.mail.models.mail_mail') | |||
| def test_mail_message_values_unicode(self): | |||
There was a problem hiding this comment.
Why removing the test ?
| @@ -14,6 +14,7 @@ | |||
| from email.utils import getaddresses | |||
| from lxml import etree | |||
| from werkzeug import urls | |||
| import idna | |||
There was a problem hiding this comment.
Could you separate global imports and partial imports (and they should be ordered)
nimda95
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 13, 2020
It has been a recurrent request from customers to be able to send email messages to email addresses containing non-ascii characters. [IDNA] is a domain extension to allow unicode characters in domain names. [SMTPUTF8] is a SMTP extension to allow unicode in any header. IDNA defines the [punycode] encoding which translates unicode to an ascii representation. This encoding MUST be used to encode domains. SMTPUTF8 is an SMTP extension that allow utf-8 in all headers on the envelope. [IDNA] https://tools.ietf.org/html/rfc5890 [SMTPUTF8] https://tools.ietf.org/html/rfc6531 [punycode] https://tools.ietf.org/html/rfc3492 Task: 2116928 opw-2229906 opw-2248251 closes odoo#47709 Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been a recurrent request from customers to be able to send email
messages to email addresses containing non-ascii characters. [IDNA] is a
domain extension to allow unicode characters in domain names. [SMTPUTF8]
is a SMTP extension to allow unicode in any header.
IDNA defines the [punycode] encoding which translates unicode to an
ascii representation. This encoding MUST be used to encode domains.
SMTPUTF8 is an SMTP extension that allow utf-8 in all headers on the
envelope.
[IDNA] https://tools.ietf.org/html/rfc5890
[SMTPUTF8] https://tools.ietf.org/html/rfc6531
[punycode] https://tools.ietf.org/html/rfc3492
Task: 2116928