Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] l10n_ar: invoice report identification name #48722

Closed
wants to merge 1 commit into from

Conversation

zaoral
Copy link
Contributor

@zaoral zaoral commented Apr 1, 2020

Show the identification type name instead of always show VAT in the customer information on the invoice report-

This changes is required after merging #45136

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Show the identification type name instead of always show VAT in the customer information on the invoice report
@C3POdoo C3POdoo added the Localization about adapting the content to a specify country (usually chart of accounts) label Apr 1, 2020
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 1, 2020
@zaoral
Copy link
Contributor Author

zaoral commented Apr 1, 2020

HI @jco-odoo
I have added here the change in l10n_ar.

I have a question, do think is ok like this or do you prefer that I add also the logic of "o.l10n_latam_country_code == 'AR'"?

@jco-odoo
Copy link
Contributor

jco-odoo commented Apr 1, 2020

@zaoral No, because then the identification type is not set anyways. And @Danisan can add the same code to l10n_cl without problem.

@jco-odoo
Copy link
Contributor

jco-odoo commented Apr 1, 2020

On the other hand: were not you going to change the invoice report anyways?

@jco-odoo
Copy link
Contributor

jco-odoo commented Apr 1, 2020

@robodoo r+

@fw-bot
Copy link
Contributor

fw-bot commented Apr 5, 2020

This pull request has forward-port PRs awaiting action (not merged or closed): #48772, #48788, #48801

hoaivan pushed a commit to hoaivan/odoo13x that referenced this pull request May 21, 2020
Show the identification type name instead of always show VAT in the customer information on the invoice report

closes odoo#48722

Signed-off-by: Josse Colpaert <jco@openerp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses Localization about adapting the content to a specify country (usually chart of accounts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants