[FW][FIX] sql_db: flush when no uid
in environment
#48757
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug has been introduced by the PR [FIX] odoo: don't commit outside of a checked call #46719
This issue prevented flushes to database when no
uid
is set in thecurrent environment.
This happens when database changes are made in
auth="none"
routes.In a MonoDB setup this was working because Odoo consider
None
,False
asnull
and was always bound to a database.Nothing prevents to write
null
in the columnscreate_uid
andwrite_uid
in database.The PR that introduced the bug wanted to block the cases where
uid
is an instance of the classRequestUID
to avoidCannot adapt type
errors.So testing that
uid
is an integer isn't enough.Two fixes were possible here, either check if
uid
is an instanceof the class
RequestUID
or if it is either an integer,False
orNone
.To avoid noise and imports from
odoo
, we test thatuid
is an instanceof
None
.The case where it is
False
is already tested in the python code:Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #48685