Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] mass_mailing: send a statistics email to the mailing responsible #49836

Closed
wants to merge 1 commit into from
Closed

[IMP] mass_mailing: send a statistics email to the mailing responsible #49836

wants to merge 1 commit into from

Conversation

std-odoo
Copy link
Contributor

@std-odoo std-odoo commented Apr 21, 2020 •
edited

Purpose

Provide a follow-up/overview of the Mailing 24 hours after its been sent.

Specifications

Send an email to the responsible of the mailing 24 hours the last email
of the mass mailing.

During the link trackers creation, extract the button label if exists
(so we can display them in the statistics email).

Technical remarks

The statistics email is sent to the responsible of each mailing in the
CRON of mass mailing.

Task-2227411

@std-odoo std-odoo requested review from a team as code owners April 21, 2020 09:03
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from b00578c to e8f0e2d Compare April 21, 2020 09:17
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 21, 2020
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from e8f0e2d to aa29b7b Compare April 21, 2020 10:47
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 21, 2020
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from aa29b7b to 03d928f Compare April 22, 2020 07:44
@std-odoo std-odoo requested review from a team as code owners April 22, 2020 07:44
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 22, 2020
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch 3 times, most recently from c81e108 to 01ecca0 Compare April 22, 2020 08:34
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 22, 2020
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from 01ecca0 to 45aa025 Compare April 22, 2020 12:17
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 22, 2020
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch 2 times, most recently from f08e01f to 6430803 Compare April 22, 2020 12:36
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 22, 2020
mart-e
mart-e reviewed Apr 23, 2020
View reviewed changes
odoo/tools/mail.py Outdated Show resolved Hide resolved
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from 6430803 to d7cc333 Compare April 23, 2020 06:48
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 23, 2020
odony
odony reviewed Apr 23, 2020
View reviewed changes
addons/mass_mailing/models/mailing.py Outdated Show resolved Hide resolved
addons/mail/models/mail_render_mixin.py Outdated Show resolved Hide resolved
odoo/addons/base/models/res_currency.py Outdated Show resolved Hide resolved
addons/link_tracker/models/mail_render_mixin.py Show resolved Hide resolved
addons/mass_mailing/data/mail_data.xml Outdated Show resolved Hide resolved
addons/mass_mailing/models/mailing.py Outdated Show resolved Hide resolved
addons/test_mass_mailing/tests/test_performance.py Outdated Show resolved Hide resolved
@tde-banana-odoo
Copy link
Contributor

Hello,

Just saying: this task is in dev, not tested nor validated, it is only a WIP ... Kind of you to review it but, hey, we may change everything in the next few days :) .

I suppose this is linked to the new notification mechanism. Just note that we create PR as soon as we start dev to have access to the diff, it does not mean it should be reviewed.

blablah draft PR blablah boarf .

Bisoutas.

@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from d7cc333 to e5d2f47 Compare April 24, 2020 06:44
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 24, 2020
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from e5d2f47 to de170ce Compare April 24, 2020 06:47
@tde-banana-odoo
Copy link
Contributor

@odony it seems you have some free time so don't forget #40821 and #40824 .

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 10, 2020
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from 4e6e406 to 9796218 Compare June 10, 2020 11:42
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 10, 2020
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from 9796218 to 44e9df2 Compare June 11, 2020 13:59
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 11, 2020
tde-banana-odoo
tde-banana-odoo reviewed Jun 12, 2020
View reviewed changes
Copy link
Contributor

@tde-banana-odoo tde-banana-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

addons/digest/data/digest_data.xml Outdated Show resolved Hide resolved
addons/digest/data/digest_data.xml Outdated Show resolved Hide resolved
addons/digest/data/digest_data.xml Show resolved Hide resolved
addons/digest/models/digest.py Show resolved Hide resolved
addons/mass_mailing/data/digest_tip_data.xml Outdated Show resolved Hide resolved
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from 44e9df2 to bb963d4 Compare June 12, 2020 11:12
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Jun 12, 2020
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from bb963d4 to a87bb4b Compare June 12, 2020 11:18
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jun 12, 2020
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from a87bb4b to 5ded016 Compare June 12, 2020 11:46
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Jun 12, 2020
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from 5ded016 to c51f841 Compare June 12, 2020 11:47
@std-odoo
[IMP] mass_mailing: send a statistics email to the mailing responsible
4f1b5f1 
Purpose
=======
Provide a follow-up/overview of the Mailing 24 hours after its been sent.

Specifications
==============
Send an email to the responsible of the mailing 24 hours the last email
of the mass mailing.

During the link trackers creation, extract the button label if exists
(so we can display them in the statistics email).

Technical remarks
=================
The statistics email is sent to the responsible of each mailing in the
CRON of mass mailing.

Task-2227411
@std-odoo std-odoo force-pushed the master-mass_mailing-kpi-std branch from c51f841 to 4f1b5f1 Compare June 12, 2020 11:57
@tde-banana-odoo
Copy link
Contributor

@robodoo r+

@robodoo robodoo added r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Jun 12, 2020
robodoo pushed a commit that referenced this pull request Jun 12, 2020
@std-odoo
[IMP] mass_mailing: send a statistics email to the mailing responsible
b168432 
Purpose
=======
Provide a follow-up/overview of the Mailing 24 hours after its been sent.

Specifications
==============
Send an email to the responsible of the mailing 24 hours the last email
of the mass mailing.

During the link trackers creation, extract the button label if exists
(so we can display them in the statistics email).

Technical remarks
=================
The statistics email is sent to the responsible of each mailing in the
CRON of mass mailing.

Task-2227411

closes #49836

Related: odoo/upgrade#1094
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo robodoo closed this Jun 12, 2020
@robodoo robodoo temporarily deployed to merge June 12, 2020 13:07 Inactive
@fw-bot fw-bot deleted the master-mass_mailing-kpi-std branch June 26, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mart-e mart-e mart-e left review comments

@odony odony odony left review comments

@Yenthe666 Yenthe666 Yenthe666 left review comments

@tde-banana-odoo tde-banana-odoo tde-banana-odoo requested changes

Assignees
No one assigned
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@std-odoo @tde-banana-odoo @mart-e @odony @Yenthe666 @C3POdoo @robodoo