Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: Long text in row overlap with header titles. #49969

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhp-odoo
Copy link

PURPOSE:
When you have long text in any row and print the report, header title of the
table will overlap with the long text itself.

Example: Long description of the product in Sale order Line overlaps titles in
PDF reports.

Actually this is wkhtmltopdf specific issue and its been raised by many users.
refer following link,
wkhtmltopdf/wkhtmltopdf#1770 (comment)

SPEC:
With this commit, we are restricting to display the header again in the next
page if table is long enough to display in the next page.
We are setting the thead's and tfoot's display property to table-row-group will
resolve the issue.

Task : 2231874

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added seen 🙂 CI 🤖 Robodoo has seen passing statuses labels Apr 22, 2020
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 22, 2020
@msh-odoo msh-odoo force-pushed the master-pdf-header-overlap-issue-dhp branch from 9028f96 to fa756c4 Compare April 24, 2020 09:03
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 24, 2020
@msh-odoo msh-odoo force-pushed the master-pdf-header-overlap-issue-dhp branch from fa756c4 to 5d33f24 Compare April 24, 2020 09:12
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 24, 2020
When you have long text in any row and print the report, header title of the
table will overlap with the long text itself.

Example: Long description of the product in Sale order Line overlaps titles in
PDF reports.

Actually this is wkhtmltopdf specific issue and its been raised by many users.
refer following link,
wkhtmltopdf/wkhtmltopdf#1770 (comment)

With this commit, we are restricting to display the header again in the next
page if table is long enough to display in the next page.

Task : 2231874
@dhp-odoo dhp-odoo force-pushed the master-pdf-header-overlap-issue-dhp branch from 5d33f24 to 787f02c Compare August 20, 2020 05:07
@robodoo robodoo added ☐ ci/runbot and removed CI 🤖 Robodoo has seen passing statuses ☐ legal/cla labels Aug 20, 2020
@qsm-odoo qsm-odoo removed their request for review December 14, 2021 15:28
Copy link
Contributor

@qsm-odoo qsm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Commit message convention problems (no uppercase in title, no point, task-XXX (not Task : XXX), ...)
  • I don't know why I am pinged for a report issue 🤷 If it's good for you all, it's good for me... 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants