[FW][FIX] mass_mailing_sms: Handle same sms_code in multiple traces #52452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue - Go to unsubsribe sms page where the 'sms_code' is the same in multiple traces - Fill the correct phone number (same one of any traces) - Click on 'Unsubscribe me' Traceback is raised. Also, if empty phone number, still have successfull message. Cause Multiple traces with same "sms_code" but different "sms_number". The current behavior does not handle multiple traces. Solution - Filter and retrieve the trace with the correct "sms_number". - Add 'required' attribute on phone number input. opw-2264200 X-original-commit: 34a8f63
|
Ping @nboulif, @nim-odoo
To merge the full chain, say
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 4, 2020
Issue - Go to unsubsribe sms page where the 'sms_code' is the same in multiple traces - Fill the correct phone number (same one of any traces) - Click on 'Unsubscribe me' Traceback is raised. Also, if empty phone number, still have successfull message. Cause Multiple traces with same "sms_code" but different "sms_number". The current behavior does not handle multiple traces. Solution - Filter and retrieve the trace with the correct "sms_number". - Add 'required' attribute on phone number input. opw-2264200 closes #52452 X-original-commit: 34a8f63 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com> Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>
fw-bot
deleted the
master-13.0-opw-2264200-mass_mailing_sms-fix-unsubscribe-bon-hFUX-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Cause
Solution
opw-2264200
Forward-Port-Of: #52414