[FIX] web: prevent destroying input when re-rendering FieldMonetary #52643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit slightly modifies the re-rendering process of the FieldMonetary widget to avoid destroying its inner input element every time. Destroying this element, in combination with 'resetOnAnyFieldChange', would cause an issue preventing the correct firing of the 'input' event on the <input> element. That could in turn prevent a tour "Tip" from correctly "consuming" due to the lack of input event, blocking the tour entirely.
awa-odoo
force-pushed
the
master-fix-monetary-field-awa
branch
from
f11e2bf
to
eb1dda0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit slightly modifies the re-rendering process of the FieldMonetary
widget to avoid destroying its inner input element every time.
Destroying this element, in combination with 'resetOnAnyFieldChange', would
cause an issue preventing the correct firing of the 'input' event on the
element.
That could in turn prevent a tour "Tip" from correctly "consuming" due to the
lack of input event, blocking the tour entirely.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr