[REM] mrp: remove unused fields + Dead code #54996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryv-odoo
force-pushed
the
master-mrp-v14-remove-dead-code-ryv
branch
from
b04e3cb
to
7fb96b6
Compare
ryv-odoo
force-pushed
the
master-mrp-v14-remove-dead-code-ryv
branch
from
7fb96b6
to
4a99569
Compare
ryv-odoo
force-pushed
the
master-mrp-v14-remove-dead-code-ryv
branch
from
4a99569
to
868c086
Compare
robodoo
added
☑ ci/upgrade_odoo
CI 🤖
- Refactor `order_finished_lot_ids` compute, to be linked to the `lot_producing_id` the the related production (less boiler plate). We can't remove it because it is used in mrp_subcontracting, and keep the Many2Many, for the tag widget. Remove the second field compute by this method, `finished_lots_exist` (never used). - Remove unused field `needs_lots` (also it is a duplication with `has_tracking` info) from `stock.move` (mrp) - Remove unused field `done_move` from `stock.move.line` (mrp). - Remove unused methods `_strict_consumption_check` and `_update_raw_move`. - Remove unused variables. odoo/upgrade#1594
ryv-odoo
force-pushed
the
master-mrp-v14-remove-dead-code-ryv
branch
from
b324bdc
to
a28c854
Compare
robodoo
added
☐ ci/runbot
CI 🤖
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Aug 20, 2020
- Refactor `order_finished_lot_ids` compute, to be linked to the `lot_producing_id` the the related production (less boiler plate). We can't remove it because it is used in mrp_subcontracting, and keep the Many2Many, for the tag widget. Remove the second field compute by this method, `finished_lots_exist` (never used). - Remove unused field `needs_lots` (also it is a duplication with `has_tracking` info) from `stock.move` (mrp) - Remove unused field `done_move` from `stock.move.line` (mrp). - Remove unused methods `_strict_consumption_check` and `_update_raw_move`. - Remove unused variables. odoo/upgrade#1594 closes #54996 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
order_finished_lot_idscompute, to be linked to thelot_producing_idthe the related production (less boiler plate). We can't remove it because
it is used in mrp_subcontracting, and keep the Many2Many, for the tag widget.
Remove the second field compute by this method,
finished_lots_exist(never used).needs_lots(also it is a duplicationwith
has_trackinginfo) fromstock.move(mrp)done_movefromstock.move.line(mrp)._strict_consumption_checkand_update_raw_move.odoo/upgrade#1594