[IMP] website_event_track_online: PWA adds prefetch for offline use #56058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pparidans
force-pushed
the
saas-13.3-event-pwa-prefetch-app
branch
from
2eb2530
to
37a5854
Compare
pparidans
force-pushed
the
saas-13.3-event-pwa-prefetch-app
branch
from
37a5854
to
c5038a3
Compare
This commit adds the prefetch of the current page's children (cf. under the same scope) to be available for offline use. For performance reason, only the first-level children are added to the cache to avoid a huge amount of requests and/or resources used by simply loading the event website's pages. Also, for the same reason, this process is delegated to the ServiceWorker to avoid cluttering the Main Thread. Note: due to some security restriction introduced in the Fetch spec, some redirects may prevent offline-requests from being properly fulfilled from the cache. See references for further details. References: - whatwg/fetch#763 - GoogleChromeLabs/sw-precache#220 - https://fetch.spec.whatwg.org/#concept-request-redirect-mode
pparidans
force-pushed
the
saas-13.3-event-pwa-prefetch-app
branch
from
eefbb03
to
4e7e6a4
Compare
robodoo
added
☐ ci/template
CI 🤖
|
@adr-odoo it's green!!!! 😎 |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Aug 19, 2020
This commit adds the prefetch of the current page's children (cf. under the same scope) to be available for offline use. For performance reason, only the first-level children are added to the cache to avoid a huge amount of requests and/or resources used by simply loading the event website's pages. Also, for the same reason, this process is delegated to the ServiceWorker to avoid cluttering the Main Thread. Note: due to some security restriction introduced in the Fetch spec, some redirects may prevent offline-requests from being properly fulfilled from the cache. See references for further details. References: - whatwg/fetch#763 - GoogleChromeLabs/sw-precache#220 - https://fetch.spec.whatwg.org/#concept-request-redirect-mode closes #56058 Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
This was referenced Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the prefetch of the current page's children (cf. under
the same scope) to be available for offline use.
For performance reason, only the first-level children are added to the
cache to avoid a huge amount of requests and/or resources used by simply
loading the event website's pages. Also, for the same reason, this
process is delegated to the ServiceWorker to avoid cluttering the Main
Thread.
Also, this PR perform some linting and ensure ES5 usage (for compatibility purpose).