[FW][REF] requirements.txt: Use gevent 1.5.0 version with fixes for >=py3.7.4 #56857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….7.4 The following commit fixes >=py3.7.4 compatibility: - gevent/gevent@9d27d26 It was released in stable version gevent==1.5.0 on April 10, 2020: - https://pypi.org/project/gevent/1.5.0/ gevent==1.3.4 was released on June 20, 2018 - https://github.com/gevent/gevent/releases/tag/1.3.4 And python3.7.0 was released June 27, 2018 - https://www.python.org/downloads/release/python-370/ So, the current pinned version 1.3.4 is not optimized for py3.7 It could be a possible reason to reproduce the following error: - odoo#50861 This change upgrades the pinned version to gevent==1.5.0 in order to get an optimized version for py3.7 Bump version to greenlet==0.4.14 for py3.7 since that it is the version defined in the sha of release of gevent==1.5.0 - gevent/gevent@a1a72cb9 - https://github.com/gevent/gevent/blob/a1a72cb9/setup.py#L188 X-original-commit: c4f7499
|
This PR targets saas-11.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
☑ legal/cla
CI 🤖
robodoo
pushed a commit
that referenced
this pull request
Sep 1, 2020
….7.4 The following commit fixes >=py3.7.4 compatibility: - gevent/gevent@9d27d26 It was released in stable version gevent==1.5.0 on April 10, 2020: - https://pypi.org/project/gevent/1.5.0/ gevent==1.3.4 was released on June 20, 2018 - https://github.com/gevent/gevent/releases/tag/1.3.4 And python3.7.0 was released June 27, 2018 - https://www.python.org/downloads/release/python-370/ So, the current pinned version 1.3.4 is not optimized for py3.7 It could be a possible reason to reproduce the following error: - #50861 This change upgrades the pinned version to gevent==1.5.0 in order to get an optimized version for py3.7 Bump version to greenlet==0.4.14 for py3.7 since that it is the version defined in the sha of release of gevent==1.5.0 - gevent/gevent@a1a72cb9 - https://github.com/gevent/gevent/blob/a1a72cb9/setup.py#L188 closes #56857 X-original-commit: c4f7499 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commit fixes >=py3.7.4 compatibility:
It was released in stable version gevent==1.5.0 on April 10, 2020:
gevent==1.3.4 was released on June 20, 2018
And python3.7.0 was released June 27, 2018
So, the current pinned version 1.3.4 is not optimized for py3.7
It could be a possible reason to reproduce the following error:
This change upgrades the pinned version to gevent==1.5.0
in order to get an optimized version for py3.7
Bump version to greenlet==0.4.14 for py3.7 since that it is the
version defined in the sha of release of gevent==1.5.0
Forward-Port-Of: #56167