[FW][FIX] fix random errors in tour tests #57145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simplified version of run method looks like this:
run: function(){
this.pause();
setTimeout(function(){
this.play();
}, 0)
window.location.href = tour.url;
}
That is, if page is not reloaded, the tour starts immediately. Unfortunately, in rare cases, the method in setTimeout is executed earlier than reloading happens. It brokes the whole tour. For example:
* phantom_js/browse_js (in python) opens "/web"
* odoo updates "/web" to "/web#action=123&...."
* method run (in js) starts loading "/web"
* few steps are executed before the reloading, e.g. step "Open Point Of Sale menu"
* headless browser reloads page back to "/web"
* tour system cannot execute next step, because we are not in Point Of Sale men
* tour system raise error
This commit simply increases the timeout in setTimeout to avoid such situations
X-original-commit: f53be0a
|
This PR targets saas-11.3 and is part of the forward-port chain. Further PRs will be created up to saas-12.3. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
☑ ci/template
CI 🤖
|
Ping @yelizariev, @d-fence
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Sep 7, 2020
The simplified version of run method looks like this:
run: function(){
this.pause();
setTimeout(function(){
this.play();
}, 0)
window.location.href = tour.url;
}
That is, if page is not reloaded, the tour starts immediately. Unfortunately, in rare cases, the method in setTimeout is executed earlier than reloading happens. It brokes the whole tour. For example:
* phantom_js/browse_js (in python) opens "/web"
* odoo updates "/web" to "/web#action=123&...."
* method run (in js) starts loading "/web"
* few steps are executed before the reloading, e.g. step "Open Point Of Sale menu"
* headless browser reloads page back to "/web"
* tour system cannot execute next step, because we are not in Point Of Sale men
* tour system raise error
This commit simply increases the timeout in setTimeout to avoid such situations
closes #57145
X-original-commit: f53be0a
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
The simplified version of run method looks like this:
That is, if page is not reloaded, the tour starts immediately. Unfortunately, in rare cases, the method in setTimeout is executed earlier than reloading happens. It brokes the whole tour. For example:
This commit simply increases the timeout in setTimeout to avoid such situations
Current behavior before PR:
Random rare annoying falsy negative results in tour tests in travis
Desired behavior after PR is merged:
Get rid of falsy negative results in CI tests
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
@it-projects-llc
Forward-Port-Of: #40049