[FW][FIX] website_mail_channel: Python 3.8 compatible #57288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Python 3.8 the digestmode arg from hmac.new is not optional anymore (see https://docs.python.org/3/library/hmac.html). This aims to keep the previous behavior in stable (11.0 to saas-13.3) while making it compatible with 3.8. Future versions shouldn't have this issue since 1c7c837 introduces a handler with explicit digestmode in saas-13.4. X-original-commit: 47de40d
|
This PR targets saas-11.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
☑ legal/cla
CI 🤖
robodoo
pushed a commit
that referenced
this pull request
Sep 10, 2020
As of Python 3.8 the digestmode arg from hmac.new is not optional anymore (see https://docs.python.org/3/library/hmac.html). This aims to keep the previous behavior in stable (11.0 to saas-13.3) while making it compatible with 3.8. Future versions shouldn't have this issue since 1c7c837 introduces a handler with explicit digestmode in saas-13.4. closes #57288 X-original-commit: 47de40d Signed-off-by: Martin Trigaux (mat) <mat@odoo.com> Signed-off-by: Thomas Dieuzeide <tdi-odoo@users.noreply.github.com>
|
I'm sorry, @tdi-odoo. This PR is already reviewed, reviewing it again is useless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Python 3.8 the digestmode arg from hmac.new
is not optional anymore (see https://docs.python.org/3/library/hmac.html).
This aims to keep the previous behavior in stable (11.0 to saas-13.3)
while making it compatible with 3.8.
Future versions shouldn't have this issue since 1c7c837 introduces
a handler with explicit digestmode in saas-13.4.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #57263