[14.0][FIX] better error catching #60260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robodoo
added
seen 🙂
CI 🤖
sebastienbeau
changed the title
|
note previous version are also impacted |
|
@rco-odoo any news? |
kevinkhao
approved these changes
Jan 25, 2021
|
@rco-odoo up |
sebastienbeau
commented
May 4, 2021
| record=stream.index, | ||
| field='.id', | ||
| message=_(u"Invalid database identifier '%s'") % dbid)) | ||
|
|
||
| if not self.search([('id', '=', dbid)]): |
There was a problem hiding this comment.
@rco-odoo what do you think about modifying the search here and adding a with_context(active_test=False) ?
Indeed if you want to import (using id) in order to active a archived product, the search will not find the id
|
@sebastienbeau knowing that 14 is no longer updated, is this PR still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
When having a custom module that reuse the load method (here is the project : https://github.com/shopinvader/pattern-import-export.
Current behavior before PR:
If you pass an invalid type of field for the id the error is not catched correctly and you have a pg traceback
Desired behavior after PR is merged:
If you pass an invalid type of field for the id the error is catched correctly.
@rco-odoo
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr