Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] stock, sale_stock: qty_at_date widget with Stock location, not … #68044

Closed
wants to merge 1 commit into from

Conversation

max3903
Copy link
Contributor

@max3903 max3903 commented Mar 17, 2021

…the whole warehouse (Issue #2484634)

What are the steps to reproduce your issue?

  • Activate multi locations
  • Create a location "Not for Sales" under "WH"
  • Add 50 office chairs in that location
  • Create a sales order for that chair
  • Open the Forecast icon on the sale order line

What is the current behavior that you observe?

  • Forecasted quantity: 85
  • Available quantity: 50

What would be your expected behavior in this case?

  • Forecasted quantity: 35
  • Available quantity: 0

The location "Not for Sales" is not under WH/Stock so the stock there should not be available for sales.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Mar 17, 2021

Pull request status dashboard

@JulioSerna
Copy link
Contributor

I had a similar issue to version12.0

This was my propose to resolve the issue
#63355

@jgrandguillaume
Copy link
Contributor

Hi,

I agree that location not underneath stock shouldn't be taken into account. This is Odoo logic since always.

Thanks for caring on that issue.

Joël

@rousseldenis
Copy link
Contributor

@amoyaux What do you think of this ? IMHO it makes sense.

@manuelfcordoba
Copy link

Hi,

I agree that location not underneath stock shouldn't be taken into account. This is Odoo logic since always.

Thanks for caring on that issue.

Joël

Exactly.. this has always been this way, and i agree it would be great to change it as max3903 proposes.

@lmignon
Copy link
Contributor

lmignon commented Mar 24, 2021

Hi,

I agree that location not underneath stock shouldn't be taken into account. This is Odoo logic since always.

Thanks for caring on that issue.

Joël

👍

@Feyensv Feyensv added the Logistics about stock, mrp, delivery, purchase label Mar 25, 2021
@amoyaux
Copy link
Contributor

amoyaux commented Mar 29, 2021

Hi,

I understand your use case. However if a location is under WH, it means it's under your warehouse. In our opinion, it's the simplest explanation and easiest to understand. You could use any other location that is not under your warehouse for your use case but I guess you still want to see the correct on hand and forecast quantities (you could use another warehouse with all the product that are not to sell for that since the popup is based on the warehouse on the sale order). Other people, could have use cases where they create a location not under lot_stock_id but still want to use them for sale. The idea is that every report or data should check under the warehouse view location (https://github.com/odoo/odoo/blob/14.0/addons/stock/models/product.py#L243 on hand, forecast quantities). The main location lot_stock_id should only be used for some default values (e.g picking type's locations or some rules). @thomasdeleval

@lathama
Copy link
Contributor

lathama commented Apr 15, 2024

@max3903 knowing that 14 is no longer updated, is this PR still needed?

@C3POdoo
Copy link
Contributor

C3POdoo commented Apr 16, 2024

Dear @max3903,

Thank you for your contribution but the version 14.0 is no longer supported.
We only support the last 3 stable versions so no longer accepts patches into this branch.

We apology if we could not look at your request in time.
If the contribution still makes sense for the upper version, please let us know and do not hesitate to recreate one for the recent versions. We will try to check it as soon as possible.

This is an automated message.

@C3POdoo C3POdoo closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Logistics about stock, mrp, delivery, purchase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet