Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: can update one2many with custom field widget #68276

Closed
wants to merge 2 commits into from

Conversation

aab-odoo
Copy link
Contributor

One might design a custom field widget to display/interact with a
one2many field. Before this commit, if this field widget triggered
a field_changed event to update a related record, it crashed,
because the code assumed that there was a view associated with the
field.

opw~2468238

Co-authored-by: Aaron Bohy aab@odoo.com

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Mar 24, 2021

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Mar 24, 2021
@aab-odoo aab-odoo force-pushed the 13.0-custom-o2m-fix-aab branch 2 times, most recently from ee6104e to c4e17da Compare March 24, 2021 09:59
aab-odoo and others added 2 commits March 24, 2021 11:00
One might design a custom field widget to display/interact with a
one2many field. Before this commit, if this field widget triggered
a field_changed event to update a related record, it crashed,
because the code assumed that there was a view associated with the
field.

Closes odoo#68276
opw~2468238

Co-authored-by: Aaron Bohy <aab@odoo.com>
@kebeclibre
Copy link
Contributor

robodoo rebase-ff r+

@robodoo
Copy link
Contributor

robodoo commented Mar 24, 2021

Merge method set to rebase and fast-forward

robodoo pushed a commit that referenced this pull request Mar 24, 2021
One might design a custom field widget to display/interact with a
one2many field. Before this commit, if this field widget triggered
a field_changed event to update a related record, it crashed,
because the code assumed that there was a view associated with the
field.

Closes #68276
opw~2468238

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Co-authored-by: Aaron Bohy <aab@odoo.com>
@robodoo robodoo closed this Mar 24, 2021
@robodoo robodoo temporarily deployed to merge March 24, 2021 11:12 Inactive
aab-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 24, 2021
One might design a custom field widget to display/interact with a
one2many field. Before this commit, if this field widget triggered
a field_changed event to update a related record, it crashed,
because the code assumed that there was a view associated with the
field.

Closes odoo#68276
opw~2468238

Co-authored-by: Aaron Bohy <aab@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 24, 2021
One might design a custom field widget to display/interact with a
one2many field. Before this commit, if this field widget triggered
a field_changed event to update a related record, it crashed,
because the code assumed that there was a view associated with the
field.

Closes #68276
opw~2468238

closes #68294

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Co-authored-by: Aaron Bohy <aab@odoo.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Mar 24, 2021
One might design a custom field widget to display/interact with a
one2many field. Before this commit, if this field widget triggered
a field_changed event to update a related record, it crashed,
because the code assumed that there was a view associated with the
field.

Closes odoo#68276
opw~2468238

X-original-commit: 3826a26
Co-authored-by: Aaron Bohy <aab@odoo.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Mar 24, 2021
One might design a custom field widget to display/interact with a
one2many field. Before this commit, if this field widget triggered
a field_changed event to update a related record, it crashed,
because the code assumed that there was a view associated with the
field.

Closes odoo#68276
opw~2468238

X-original-commit: 3826a26
Co-authored-by: Aaron Bohy <aab@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 24, 2021
One might design a custom field widget to display/interact with a
one2many field. Before this commit, if this field widget triggered
a field_changed event to update a related record, it crashed,
because the code assumed that there was a view associated with the
field.

Closes #68276
opw~2468238

closes #68304

X-original-commit: 3826a26
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Co-authored-by: Aaron Bohy <aab@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 24, 2021
One might design a custom field widget to display/interact with a
one2many field. Before this commit, if this field widget triggered
a field_changed event to update a related record, it crashed,
because the code assumed that there was a view associated with the
field.

Closes #68276
opw~2468238

closes #68309

X-original-commit: 3826a26
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Co-authored-by: Aaron Bohy <aab@odoo.com>
@fw-bot fw-bot deleted the 13.0-custom-o2m-fix-aab branch April 7, 2021 11:47
fmdl pushed a commit to fmdl/odoo that referenced this pull request Apr 29, 2021
One might design a custom field widget to display/interact with a
one2many field. Before this commit, if this field widget triggered
a field_changed event to update a related record, it crashed,
because the code assumed that there was a view associated with the
field.

Closes odoo#68276
opw~2468238

closes odoo#68294

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Co-authored-by: Aaron Bohy <aab@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants