[IMP] sms: Fallback on partner if records don't inherit mail.thread #71020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, trying to use the sms composer on a record that is not inheriting mail.thread and has a phone field that is related to a partner would be considered invalid and users would have to retype the number themselves. After this commit, if the sms composer is used one a phone field from a record that does not inherit mail.thread but has a partner_id, it will use the related partner mail.thread abilities to get the recipients info instead of just considering the number to be invalid. LINKS: TaskID: 2514622 PR: #xxxxx
qmo-odoo
force-pushed
the
master-sms-composer-on-related-fields-qmo
branch
from
a07c2e5
to
e7f9f94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, trying to use the sms composer on a record that is not inheriting
mail.thread and has a phone field that is related to a partner would be considered invalid
and users would have to retype the number themselves.
After this commit, if the sms composer is used one a phone field from a record that does not
inherit mail.thread but has a partner_id, it will use the related partner mail.thread abilities
to get the recipients info instead of just considering the number to be invalid.
LINKS:
TaskID: 2514622
PR: #xxxxx
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr