[FIX] survey: Unescape characters in mail subject

[adwid]

To reproduce the error:
Create a survey (title must contain ") and send it

Error:
The mail subject is incorrect: the character " is replaced with "

OPW-2536206

[adwid]

@nle-odoo

[robodoo]

[tde-banana-odoo]

That's really strange as it would be the case with all char-based jinja fields. Safe is used to enable html, why should it be required here ?

[adwid]

@tde-banana-odoo I think that most of the time, jinja fields are rendered inside html body, which is not the case for the mail subject
Here, safe prevents automatic escaping

[nle-odoo]

in most case we don't use jinja autoescape on mail subject after this change: http://github.com/odoo/odoo/commit/6dde919bb9850912f618b561cd2141bffe41340c

so here we should have safe=True in context of:

odoo/addons/survey/wizard/survey_invite.py

Line 199 in 8ffd822

subject = self.env['mail.template']._render_template(self.subject, 'survey.user_input', answer.id, post_process=True)

edit: checking _render_template.*subject there is 5 more locations where we do this without safe in context

[tde-banana-odoo]

I would say don't use context and add pipes, but this would break translations, so I suppose go for context indeed.

[nle-odoo]

robodoo r+