stock add is_signed boolean computed field #72592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signaature field was used in listview and it was displaying size of the signature file, it has been done in commit: 4bdbb9b but as discussed on PR: odoo#72276 we added is_signed computed boolean field to display it like boolean as boolean widget is supported only on boolean type field. task-2580117
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 24, 2021
signaature field was used in listview and it was displaying size of the signature file, it has been done in commit: 4bdbb9b but as discussed on PR: #72276 we added is_signed computed boolean field to display it like boolean as boolean widget is supported only on boolean type field. task-2580117 closes #72592 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
|
@msh-odoo I have a question about this commit. Why not store the field is_signed to db? Every time the tree view is displayed, the field is compute again and again. I think this would be a performance issue. |
|
@tanghulu0608 I don't think so, compute method is not complex as well as it has dependency of signature field, also storing it doesn't make sense as just added compute field just for display purpose, what do you think @amoyaux |
|
@amoyaux hello |
|
It won't be an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PURPOSE
Show signed field in stock.picking listview as boolean widget.
SPEC
Add is_signed computed boolean field and add it into stock.picking listview.
TASK 2580117
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr