[IMP] Ecuadorian Localization #75055

cormaza · 2021-08-12T18:56:59Z

Chart of Account based on IFRS
Validation for RUCs and CI for Ecuadorian VAT
Taxes and Groups - minimum
Initial Structure for 103 and 104 Reports to SRI
Entity, Point of Emission, address of emission, and type of emission added to journal
SRI payment methods, used on EDI Process
Ecuadorian Banks data
Latam Identification Types
Latam Document Types Related

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

robodoo · 2021-08-12T18:57:22Z

Pull request status dashboard.

vbe-odoo · 2021-08-17T15:34:15Z

@jco-odoo ping

jco-odoo

A couple of things to talk about.

addons/l10n_ec/__manifest__.py

addons/l10n_ec/data/account.account.template.csv

addons/l10n_ec/data/account_chart_template_configure_data.xml

addons/l10n_ec/data/account_chart_template_data.xml

addons/l10n_ec/models/account_move.py

addons/l10n_ec/models/account_tax_group.py

addons/l10n_ec/models/l10n_latam_document_type.py

odoo/addons/base/data/res.country.state.csv

addons/l10n_ec/models/res_partner.py

addons/l10n_ec/__manifest__.py

addons/l10n_ec/data/l10n_ec_identification_type_data.xml

addons/l10n_ec/data/account_chart_template_setup_accounts.xml

jco-odoo

Can we leave out l10n_ec_extra_tax for the moment (and add it later on after the freeze) A lot to handle still...

addons/l10n_ec/data/account_chart_template_configure_data.xml

addons/l10n_ec/data/account_chart_template_setup_accounts.xml

addons/l10n_ec/data/l10n_latam_identification_type_data.xml

addons/l10n_ec/models/account_move.py

addons/l10n_ec/data/l10n_latam.document.type.csv

addons/l10n_ec/models/account_journal.py

addons/l10n_ec/models/account_move.py

addons/base_vat/models/res_partner.py

addons/l10n_ec/models/account_move.py

jco-odoo

Can you still check?

addons/l10n_ec/models/account_move.py

addons/l10n_ec/models/l10n_ec_sri_payment.py

addons/l10n_ec/data/l10n.ec.sri.payment.csv

addons/l10n_ec/data/res.bank.csv

opa-cormaza · 2021-08-31T22:24:54Z

@jco-odoo Maybe can this method has an issue

odoo/addons/l10n_cl/models/account_move.py

Lines 117 to 119 in a8e6b57

    
           where_string += ' AND l10n_latam_document_type_id = %(l10n_latam_document_type_id)s AND ' \ 
        
                           'company_id = %(company_id)s AND move_type IN (\'out_invoice\', \'out_refund\')' 
        
           param['company_id'] = self.company_id.id or False

I'm not sure but in this case we are asking for company, when journals already has company

opa-cormaza · 2021-09-01T14:06:34Z

Check this lines

odoo/addons/l10n_cl/demo/account_demo.py

Lines 29 to 41 in 33476a4

    
           def _get_demo_data_move(self): 
        
               ref = self.env.ref 
        
               cid = self.env.company.id 
        
               foreign = ref('l10n_cl.dc_fe_dte').id 
        
               model, data = super()._get_demo_data_move() 
        
               self.env['account.journal'].search([ 
        
                   ('type', '=', 'purchase'), 
        
                   ('company_id', '=', self.env.company.id), 
        
               ]).l10n_latam_use_documents = False 
        
               data[f'{cid}_demo_invoice_1']['l10n_latam_document_type_id'] = foreign 
        
               data[f'{cid}_demo_invoice_2']['l10n_latam_document_type_id'] = foreign 
        
               data[f'{cid}_demo_invoice_3']['l10n_latam_document_type_id'] = foreign 
        
               data[f'{cid}_demo_invoice_followup']['l10n_latam_document_type_id'] = foreign

It should ask if is a cl company to change latam_document_type, this is changing in ec document type, and make issue, this commit should change this behavior?

@jco-odoo @vbe-odoo

odony · 2021-09-02T16:49:25Z

addons/base_vat/models/res_partner.py

@@ -251,6 +253,65 @@ def check_vat_ch(self, vat):
            return check == int(num[8])
        return False

+    def _checksum_ci_ec(self, number):


Why would you need to copy all the validation code from stdnum? it's a dependency, you can call it. There are even handy shortcuts:
stdnum.util.get_cc_module("ec", "ci")
stdnum.util.get_cc_module("ec", "ruc")

PS: please never copy code without giving attribution, copyright and license, that's not nice (and it violates the original license, copyright law, and the Odoo CLA) ;)

odony · 2021-09-02T17:00:09Z

doc/cla/individual/opa-cormaza.md

@@ -0,0 +1,11 @@
+Ecuador, 2021-08-20
+
+I hereby agree to the terms of the Odoo Individual Contributor License


It seems your company has already signed the Corporate CLA, so unless you own the copyright to this code personally, your name should be added instead in the contributors for your organization:
https://github.com/odoo/odoo/blob/master/doc/cla/corporate/opa-consulting.md

The CLA implies that you are granting a license to all code you contribute, so you must be the copyright owner. In many companies and countries, employment contracts have a clause where the copyright of the works employees produce for the company (including code) belongs to the company. You may need to double-check that :)

robodoo · 2021-09-02T21:55:02Z

Staging failed: ci/runbot on 848be48463e7732cdd412c68644684900f8eb86e (view more at http://runbot.odoo.com/runbot/build/9780752)

jco-odoo · 2021-09-03T12:37:41Z

@robodoo retry

- Added own implementation, for CI and RUC Validation Part-of: #75055

- Chart of Account based on IFRS - Validation for RUCs and CI for Ecuadorian VAT - Taxes and Groups - minimum - Initial Structure for 103 and 104 Reports to SRI - Entity, Point of Emission, address of emission, and type of emission added to journal - SRI payment methods, used on EDI Process - Ecuadorian Banks data - Latam Identification Types - Latam Document Types Related closes #75055 Signed-off-by: Josse Colpaert <jco@openerp.com>

- Chart of Account based on IFRS - Validation for RUCs and CI for Ecuadorian VAT - Taxes and Groups - minimum - Initial Structure for 103 and 104 Reports to SRI - Entity, Point of Emission, address of emission, and type of emission added to journal - SRI payment methods, used on EDI Process - Ecuadorian Banks data - Latam Identification Types - Latam Document Types Related

jco-odoo · 2021-09-03T14:01:15Z

@robodoo r+

Xavier-Do · 2021-09-03T14:04:09Z

Can you please avoid such random retry/push/r+ in freeze period? You just cancelled an almost merged batch.

- Added own implementation, for CI and RUC Validation Part-of: #75055

- Chart of Account based on IFRS - Validation for RUCs and CI for Ecuadorian VAT - Taxes and Groups - minimum - Initial Structure for 103 and 104 Reports to SRI - Entity, Point of Emission, address of emission, and type of emission added to journal - SRI payment methods, used on EDI Process - Ecuadorian Banks data - Latam Identification Types - Latam Document Types Related closes #75055 Signed-off-by: Josse Colpaert <jco@openerp.com>

jco-odoo reviewed Aug 20, 2021

View reviewed changes

addons/l10n_ec/__manifest__.py Outdated Show resolved Hide resolved

jco-odoo reviewed Aug 20, 2021

View reviewed changes

addons/l10n_ec/data/l10n_ec_identification_type_data.xml Outdated Show resolved Hide resolved

jco-odoo reviewed Aug 20, 2021

View reviewed changes

addons/l10n_ec/data/account_chart_template_setup_accounts.xml Show resolved Hide resolved

jco-odoo requested changes Aug 23, 2021

View reviewed changes

vbe-odoo reviewed Aug 24, 2021

View reviewed changes

addons/l10n_ec/models/account_move.py Outdated Show resolved Hide resolved

jco-odoo requested changes Aug 25, 2021

View reviewed changes

addons/l10n_ec/models/account_move.py Outdated Show resolved Hide resolved

addons/l10n_ec/models/account_move.py Outdated Show resolved Hide resolved

addons/base_vat/models/res_partner.py Outdated Show resolved Hide resolved

jco-odoo reviewed Aug 25, 2021

View reviewed changes

addons/l10n_ec/models/account_move.py Show resolved Hide resolved

cormaza changed the title ~~l10n_ec V15 WIP~~ [IMP] Ecuadorian Localization Aug 26, 2021

opa-cormaza force-pushed the l10n_ec_v15 branch 2 times, most recently from cefd9ed to 0c8aeec Compare August 30, 2021 18:11

jco-odoo reviewed Aug 31, 2021

View reviewed changes

addons/l10n_ec/models/account_move.py Outdated Show resolved Hide resolved

addons/l10n_ec/models/account_move.py Outdated Show resolved Hide resolved

jco-odoo reviewed Aug 31, 2021

View reviewed changes

addons/l10n_ec/models/l10n_ec_sri_payment.py Outdated Show resolved Hide resolved

jco-odoo reviewed Aug 31, 2021

View reviewed changes

addons/l10n_ec/data/l10n.ec.sri.payment.csv Outdated Show resolved Hide resolved

jco-odoo reviewed Aug 31, 2021

View reviewed changes

addons/l10n_ec/data/res.bank.csv Outdated Show resolved Hide resolved

opa-cormaza force-pushed the l10n_ec_v15 branch from 79aedad to ecd949a Compare September 1, 2021 16:02

C3POdoo requested review from a team September 1, 2021 16:04

odony reviewed Sep 2, 2021

View reviewed changes

seb-odoo removed request for a team September 2, 2021 22:35

sdegueldre removed the request for review from a team September 3, 2021 05:21

jco-odoo removed request for a team September 3, 2021 09:44

robodoo pushed a commit that referenced this pull request Sep 3, 2021

[IMP] base_vat: CI and Ruc Validation for Ecuadorian Context

e1739a0

- Added own implementation, for CI and RUC Validation Part-of: #75055

cormaza force-pushed the l10n_ec_v15 branch from de1cf80 to 191f5b8 Compare September 3, 2021 13:58

robodoo pushed a commit that referenced this pull request Sep 3, 2021

[IMP] base_vat: CI and Ruc Validation for Ecuadorian Context

d93365c

- Added own implementation, for CI and RUC Validation Part-of: #75055

robodoo added the 14.5 label Sep 3, 2021

robodoo closed this Sep 3, 2021

robodoo temporarily deployed to merge September 3, 2021 16:54 Inactive

william-andre mentioned this pull request Nov 18, 2021

Ecuador Localization #59125

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] Ecuadorian Localization #75055

[IMP] Ecuadorian Localization #75055

cormaza commented Aug 12, 2021 •

edited

robodoo commented Aug 12, 2021

vbe-odoo commented Aug 17, 2021

jco-odoo left a comment

jco-odoo left a comment

jco-odoo left a comment

opa-cormaza commented Aug 31, 2021

opa-cormaza commented Sep 1, 2021

odony Sep 2, 2021

odony Sep 2, 2021

robodoo commented Sep 2, 2021

jco-odoo commented Sep 3, 2021

jco-odoo commented Sep 3, 2021

Xavier-Do commented Sep 3, 2021

		@@ -0,0 +1,11 @@
		Ecuador, 2021-08-20

		I hereby agree to the terms of the Odoo Individual Contributor License

[IMP] Ecuadorian Localization #75055

[IMP] Ecuadorian Localization #75055

Conversation

cormaza commented Aug 12, 2021 • edited

robodoo commented Aug 12, 2021

vbe-odoo commented Aug 17, 2021

jco-odoo left a comment

Choose a reason for hiding this comment

jco-odoo left a comment

Choose a reason for hiding this comment

jco-odoo left a comment

Choose a reason for hiding this comment

opa-cormaza commented Aug 31, 2021

opa-cormaza commented Sep 1, 2021

odony Sep 2, 2021

Choose a reason for hiding this comment

odony Sep 2, 2021

Choose a reason for hiding this comment

robodoo commented Sep 2, 2021

jco-odoo commented Sep 3, 2021

jco-odoo commented Sep 3, 2021

Xavier-Do commented Sep 3, 2021

cormaza commented Aug 12, 2021 •

edited