[FIX] account_invoice: use tax groups correctly #76855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C3POdoo
requested review from
a team and
FlorianGilbert
and removed request for
a team
With the previous fix, tax groups would not work correctly when checking if a tax affected a subsequent tax. With this fix, all taxes that are not of amount_type group are aggregated before following the normal flow. opw-2497281
Sehnde
force-pushed
the
12.0-opw-2497281-fix_discount_in_tax_group-snd
branch
from
ffd9d23
to
0d28b57
Compare
oco-odoo
approved these changes
Sep 29, 2021
|
@fw-bot ignore I tested in 12.3: works fine there :) |
|
Forward-port disabled. |
|
Perfect, thanks a lot |
robodoo
pushed a commit
that referenced
this pull request
Sep 29, 2021
With the previous fix, tax groups would not work correctly when checking if a tax affected a subsequent tax. With this fix, all taxes that are not of amount_type group are aggregated before following the normal flow. opw-2497281 closes #76855 Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous fix, tax groups would not work correctly when checking
if a tax affected a subsequent tax.
With this fix, all taxes that are not of amount_type group are aggregated
before following the normal flow.
This also takes care of cases when a user uses both taxes and tax groups
on a single invoice line.
opw-2497281
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr