[FIX] stock: avoid write on move when create return line #77100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ticodoo
reviewed
Sep 24, 2021
| @@ -14,7 +14,7 @@ class ReturnPickingLine(models.TransientModel): | |||
|
|
|||
| product_id = fields.Many2one('product.product', string="Product", required=True, domain="[('id', '=', product_id)]") | |||
| quantity = fields.Float("Quantity", digits=dp.get_precision('Product Unit of Measure'), required=True) | |||
| uom_id = fields.Many2one('uom.uom', string='Unit of Measure', related='move_id.product_uom', readonly=False) | |||
| uom_id = fields.Many2one('uom.uom', string='Unit of Measure', related='move_id.product_uom') | |||
There was a problem hiding this comment.
Suggested change
| uom_id = fields.Many2one('uom.uom', string='Unit of Measure', related='move_id.product_uom') | |
| uom_id = fields.Many2one('uom.uom', string='Unit of Measure', related='product_id.uom_id') |
There was a problem hiding this comment.
@ticodoo updated the related value and added a test in case of outgoing move's uom is different from product's uom
When creating a wizard `stock.return.picking` and call `_onchange_picking_id`, the creation of return picking line will perform a write on move linked with it, due to `uom_id` being set as related with `readonly=False`. Set `readonly` to `True` to avoid it
hoangtrann
force-pushed
the
saas-12.3-fix-onchange-trigger-write-on-related-model-hoangtrann
branch
from
5cee017
to
006fa29
Compare
|
Thank you for your contribution! |
robodoo
pushed a commit
that referenced
this pull request
Sep 24, 2021
When creating a wizard `stock.return.picking` and call `_onchange_picking_id`, the creation of return picking line will perform a write on move linked with it, due to `uom_id` being set as related with `readonly=False`. Set `readonly` to `True` to avoid it closes #77100 Signed-off-by: Tiffany Chang <tic@odoo.com>
This was referenced Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a wizard
stock.return.pickingand call_onchange_picking_id, the creation of return picking line will performa write on move linked with it, due to
uom_idbeing set as related withreadonly=False. SetreadonlytoTrueto avoid itThis starts with #76923
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr