Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] event_booth_sale: set correct product type for 'Event Booth' product #77146

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Sep 24, 2021

PURPOSE

The default product type of 'Event Booth' product should be 'Event Booth'.
The purpose of this commit is to set the default product type as 'Event Booth'.

SPECIFICATIONS

Right now, when we only have the event installed and activate
the Booth Management, The 'Event Booth' product has a Service type.

This fixes the default product type.

This is the goal of this commit.

LINKS

PR #76801
Task-2648950
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #76801

…oduct

When booth management is activated, we have a dedicated product for the event
booth. Currently, the product type for this product is set as 'Service'.

This happens after a recent commit[1]. With this commit, we now have a
dedicated detailed product type for event booth, but in data file of
booth product it is set to `service`, which in this case should be
`event_booth`. Apart from that, when creating a booth product for event
booth category, the product type is set as 'consumable', which should
be 'service'.

This commit updates the data for the default booth product and sets the
detailed product type to `event_booth`. And this commit also passes
correct context when creating a product for the event booth category so
that the product type is now set as 'service'.

commit[1] - odoo@3d7b9bb

Task-2648950

X-original-commit: e466430
@robodoo robodoo added the forwardport This PR was created by @fw-bot label Sep 24, 2021
@robodoo
Copy link
Contributor

robodoo commented Sep 24, 2021

@fw-bot
Copy link
Contributor Author

fw-bot commented Sep 24, 2021

Ping @mish-odoo, @tde-banana-odoo
This PR targets master and is the last of the forward-port chain.

To merge the full chain, say

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the RD research & development, internal work label Sep 24, 2021
@tde-banana-odoo
Copy link
Contributor

@fw-bot r+

robodoo pushed a commit that referenced this pull request Sep 24, 2021
…oduct

When booth management is activated, we have a dedicated product for the event
booth. Currently, the product type for this product is set as 'Service'.

This happens after a recent commit[1]. With this commit, we now have a
dedicated detailed product type for event booth, but in data file of
booth product it is set to `service`, which in this case should be
`event_booth`. Apart from that, when creating a booth product for event
booth category, the product type is set as 'consumable', which should
be 'service'.

This commit updates the data for the default booth product and sets the
detailed product type to `event_booth`. And this commit also passes
correct context when creating a product for the event booth category so
that the product type is now set as 'service'.

commit[1] - 3d7b9bb

Task-2648950

closes #77146

X-original-commit: e466430
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo robodoo added the 15.1 label Sep 24, 2021
@robodoo robodoo closed this Sep 24, 2021
@robodoo robodoo temporarily deployed to merge September 24, 2021 14:00 Inactive
@fw-bot fw-bot deleted the master-saas-14.5-event_booth_sale-change_default-product-type-mish-705h-fw branch October 8, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15.1 forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants