[FIX] sale: correctly get AML lines with downpayment

[sswapnesh]

Steps:

• Create AML which is linked to multiple Down payment SO lines
• Post Invoice

Issue:

• Traeback due to accessing field on m2m sale_line_ids field

Fix:

• Filter the SO lines based on is_downpayment field.
  Fixes: Post Invoice with lines with mulltiple Sale lines #77028

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[robodoo]

Pull request status dashboard.

[Feyensv]

Seems correct, even if I don't really see the flow to reproduce the bug in standard 🤔

[mbcosta]

Thanks @sswapnesh for solving,

There is another problem related to reference multiple sale lines to one invoice line, maybe should be solve in another PR, the field qty_invoiced in sale.order.line show the quantity of invoice line without consider, in this case, that the value is the sum of others sale lines https://github.com/odoo/odoo/blob/14.0/addons/sale/models/sale.py#L1230, what can make confuse the user about the real Invoiced Quantity:

[sswapnesh]

@Feyensv Can this be merged ?

[Feyensv]

After more thoughts, I prefer to avoid merging stable changes unless you can really reproduce this traceback with a standard flow (AFAIK, we never link one AML with multiple SOL in standard flows 🤔)

[sswapnesh]

@Feyensv What do you think to correct this on new versions to make this one to one ?
May be an internal Task ?

[Feyensv]

There is no such thing as a Onetoone field :D.

[sswapnesh]

There is no such thing as a Onetoone field :D.

😄 It was there in Past 😉
What I mean is to make it m2o

[Feyensv]

Oh indeed, I thought it was already a m2o/o2m pair, but those are two m2m surprisingly.
Well, this would require a migration script and more job for us & OpenUpgrade, so I believe we could leave it like that, even if I recognize it's a bit confusing ^^.

[C3POdoo]

Dear @sswapnesh,

Thank you for your contribution but the version 14.0 is no longer supported.
We only support the last 3 stable versions so no longer accepts patches into this branch.

We apology if we could not look at your request in time.
If the contribution still makes sense for the upper version, please let us know and do not hesitate to recreate one for the recent versions. We will try to check it as soon as possible.

This is an automated message.