[FW][FIX] registry: make invalidation flags thread-specific #77233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The registry attributes 'registry_invalidated' and 'cache_invalidated' are used to flag that the current request has modified the registry or invalidated the ormcache, respectively. This provides a simple yet efficient way to signal registry changes or cache invalidations to other workers. However, those flags were not meant to be used with multi-threaded workers. For instance, a thread may signal registry changes that are actually made by another thread. It can also happen that a thread changes the registry, which makes another thread crash (like a thread modifying a dict while another one iterates over it), and the latter will reset the registry to its original state because it misinterprets the registry changes as its own changes. The situation can even get worse, making threads crash in cascade and eventually leaving the registry in an inconsistent state. When this happens, the worker is broken and has to be manually restarted. The fix consists in making those flags thread-specific. This does not prevent thread crashing because of concurrent changes, but at least it avoids leaving the worker in a broken state. X-original-commit: cdbd315
|
This PR targets saas-12.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Sep 27, 2021
The registry attributes 'registry_invalidated' and 'cache_invalidated' are used to flag that the current request has modified the registry or invalidated the ormcache, respectively. This provides a simple yet efficient way to signal registry changes or cache invalidations to other workers. However, those flags were not meant to be used with multi-threaded workers. For instance, a thread may signal registry changes that are actually made by another thread. It can also happen that a thread changes the registry, which makes another thread crash (like a thread modifying a dict while another one iterates over it), and the latter will reset the registry to its original state because it misinterprets the registry changes as its own changes. The situation can even get worse, making threads crash in cascade and eventually leaving the registry in an inconsistent state. When this happens, the worker is broken and has to be manually restarted. The fix consists in making those flags thread-specific. This does not prevent thread crashing because of concurrent changes, but at least it avoids leaving the worker in a broken state. closes #77233 X-original-commit: cdbd315 Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registry attributes 'registry_invalidated' and 'cache_invalidated'
are used to flag that the current request has modified the registry or
invalidated the ormcache, respectively. This provides a simple yet
efficient way to signal registry changes or cache invalidations to other
workers.
However, those flags were not meant to be used with multi-threaded
workers. For instance, a thread may signal registry changes that are
actually made by another thread. It can also happen that a thread
changes the registry, which makes another thread crash (like a thread
modifying a dict while another one iterates over it), and the latter
will reset the registry to its original state because it misinterprets
the registry changes as its own changes.
The situation can even get worse, making threads crash in cascade and
eventually leaving the registry in an inconsistent state. When this
happens, the worker is broken and has to be manually restarted.
The fix consists in making those flags thread-specific. This does not
prevent thread crashing because of concurrent changes, but at least it
avoids leaving the worker in a broken state.
Forward-Port-Of: #77178