[FW][FIX] web: more reliably avoid downloads on new file #77703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robodoo
added
conflict
|
Ping @xmo-odoo cherrypicking of pull request #77603 failed. stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
xmo-odoo
force-pushed
the
saas-12.3-11.0-cleanup-binary-xmo-6f97-fw
branch
from
7c17767
to
43a5d43
Compare
|
@robodoo r+ |
5195550 mitigated an issue of being able to try and download files which don't exist yet, make the fix more reliable by clearing out the field completely and hiding the content if the (readonly) field has no value *or the record is not saved yet*. Also clean up the code: * an old-style forward port created a duplicate fixprovement (a8d01cb) which seems less correct as it applies conditionally * and the code is branchier than necessary, we can make it simpler by judiciously leveraging jquery's API X-original-commit: 0eccd39
xmo-odoo
force-pushed
the
saas-12.3-11.0-cleanup-binary-xmo-6f97-fw
branch
from
43a5d43
to
d2656cc
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Oct 4, 2021
5195550 mitigated an issue of being able to try and download files which don't exist yet, make the fix more reliable by clearing out the field completely and hiding the content if the (readonly) field has no value *or the record is not saved yet*. Also clean up the code: * an old-style forward port created a duplicate fixprovement (a8d01cb) which seems less correct as it applies conditionally * and the code is branchier than necessary, we can make it simpler by judiciously leveraging jquery's API closes #77703 X-original-commit: 0eccd39 Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
This was referenced Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5195550 mitigated an issue of being
able to try and download files which don't exist yet, make the fix
more reliable by clearing out the field completely before only
re-inserting content.
Also clean up the code:
(a8d01cb) which seems less correct
as it applies conditionally
judiciously leveraging jquery's API
Forward-Port-Of: #77603