Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] base_import: fix the default value for the selection fields #80455

Draft
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

std-odoo
Copy link
Contributor

Bug

When we import an Excel sheet, we might have wrong value for a selection
field. If it's the case, we have an option to set a default value when
the one in the file match nothing.

This feature failed and no default value will be set.

Task-2688176

@robodoo
Copy link
Contributor

robodoo commented Nov 26, 2021

@C3POdoo C3POdoo added the RD research & development, internal work label Nov 26, 2021
@std-odoo std-odoo force-pushed the 15.0-base_import-def-selection-2021-std branch from b062167 to 1e85217 Compare November 30, 2021 09:29
Copy link
Contributor

@dbeguin dbeguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one remark, otherwise, look good ! :)

Comment on lines 350 to 354
} else if (['boolean', 'selection'].includes(type) && this.value !== 'prevent') {
options.fallback_values[field] = {
fallback_value: this.value,
field_model: this.getAttribute('model'),
field_type: type
field_type: type,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's a bug and we merge in stable, this is noise.

@std-odoo std-odoo force-pushed the 15.0-base_import-def-selection-2021-std branch from 1e85217 to 1aba72e Compare December 2, 2021 07:36
Bug
===
When we import an Excel sheet, we might have wrong value for a selection
field. If it's the case, we have an option to set a default value when
the one in the file match nothing.

This feature failed and no default value will be set.

Task-2688176
@std-odoo std-odoo force-pushed the 15.0-base_import-def-selection-2021-std branch from 1aba72e to a3207f0 Compare December 2, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants