Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] *: Convert single create method into multi #80824

Closed
wants to merge 2 commits into from
Closed

[IMP] *: Convert single create method into multi #80824

wants to merge 2 commits into from

Conversation

tivisse
Copy link
Contributor

@tivisse tivisse commented Dec 3, 2021

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Dec 3, 2021

Pull request status dashboard.

@tivisse tivisse force-pushed the master-create-yti branch 2 times, most recently from a460c3c to 165dc60 Compare December 3, 2021 09:18
@C3POdoo C3POdoo requested review from a team December 3, 2021 09:20
@C3POdoo C3POdoo added the RD research & development, internal work label Dec 3, 2021
Feyensv
Feyensv reviewed Dec 3, 2021
View reviewed changes
Copy link
Contributor

@Feyensv Feyensv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wip review

addons/stock/models/res_company.py Outdated Show resolved Hide resolved
addons/stock/models/stock_package_level.py Outdated Show resolved Hide resolved
addons/stock/models/stock_warehouse.py Show resolved Hide resolved
addons/stock_picking_batch/models/stock_picking_batch.py Outdated Show resolved Hide resolved
addons/website_forum/models/forum.py Show resolved Hide resolved
addons/website_sale/models/product_misc.py
Comment on lines +54 to +55
# YTI FIXME: The fix is not at the correct place
# It be set when we actually create the pricelist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO fix 👀

addons/website_slides/wizard/slide_channel_invite.py Outdated Show resolved Hide resolved
odoo/addons/base/tests/test_create.py Outdated Show resolved Hide resolved
addons/account_check_printing/models/account_journal.py Outdated Show resolved Hide resolved
addons/base_address_extended/tests/test_street_fields.py Outdated Show resolved Hide resolved
@qdp-odoo qdp-odoo self-requested a review December 6, 2021 10:05
kbapt
kbapt suggested changes Dec 6, 2021
View reviewed changes
addons/hr_contract/models/hr_contract.py Outdated Show resolved Hide resolved
addons/hr_holidays/models/hr_employee.py Outdated Show resolved Hide resolved
addons/hr_recruitment/models/hr_recruitment.py Outdated Show resolved Hide resolved
amoyaux
amoyaux reviewed Dec 6, 2021
View reviewed changes
addons/stock/models/stock_quant.py Outdated Show resolved Hide resolved
addons/stock/models/stock_quant.py Show resolved Hide resolved
IT-Ideas
IT-Ideas reviewed Dec 6, 2021
View reviewed changes
Copy link
Contributor

@IT-Ideas IT-Ideas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂

addons/project_timesheet_holidays/models/hr_employee.py Outdated Show resolved Hide resolved
addons/project_timesheet_holidays/models/hr_employee.py Outdated Show resolved Hide resolved
addons/project_timesheet_holidays/models/hr_employee.py Show resolved Hide resolved
xavierbol
xavierbol reviewed Dec 6, 2021
View reviewed changes
Copy link
Contributor

@xavierbol xavierbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙂

addons/purchase_requisition/models/purchase.py Show resolved Hide resolved
awa-odoo
awa-odoo reviewed Dec 6, 2021
View reviewed changes
Copy link
Contributor

@awa-odoo awa-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tivisse

Very nice cleaning!
Had a quick look at our modules and left a few comments/suggestions.

Cheers.

addons/mail_plugin/models/res_partner.py Outdated Show resolved Hide resolved
addons/note/models/note.py Outdated Show resolved Hide resolved
addons/website_slides/models/slide_slide.py Outdated Show resolved Hide resolved
addons/website_slides_survey/models/slide_slide.py Outdated Show resolved Hide resolved
tde-banana-odoo
tde-banana-odoo reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@tde-banana-odoo tde-banana-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR ! Nice technical cleaning :) I did a validation for SM + base.

addons/mail_plugin/models/res_partner.py Show resolved Hide resolved
addons/mail_plugin/models/res_partner.py Outdated Show resolved Hide resolved
addons/mail_plugin/models/res_partner.py Outdated Show resolved Hide resolved
addons/resource/models/resource_mixin.py Outdated Show resolved Hide resolved
addons/resource/models/resource_mixin.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_sequence.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_sequence.py Outdated Show resolved Hide resolved
odoo/addons/base/models/res_company.py Outdated Show resolved Hide resolved
odoo/addons/base/models/res_company.py Show resolved Hide resolved
odoo/addons/base/tests/common.py Show resolved Hide resolved
rco-odoo
rco-odoo reviewed Dec 7, 2021
View reviewed changes
odoo/api.py Outdated Show resolved Hide resolved
tivisse and others added 2 commits December 14, 2021 14:08
@tivisse @Feyensv
[IMP] *: Convert single create method into multi
f7a09bc 
TaskID: 2703085

Co-authored-by: Victor Feyens <vfe@odoo.com>
@rco-odoo @tivisse
[FIX] core: create() always inverses fields in the same order
be7785b 
This makes the inversion of fields deterministic, as some orderings make
street fields crash in module base_address_extended.
@tivisse
Copy link
Contributor Author

tivisse commented Dec 14, 2021

@robodoo r+ rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Dec 14, 2021

Merge method set to rebase and fast-forward

@robodoo
Copy link
Contributor

robodoo commented Dec 14, 2021

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/11601753)

@rco-odoo
Copy link
Member

@robodoo retry

robodoo pushed a commit that referenced this pull request Dec 14, 2021
@tivisse @Feyensv
[IMP] *: Convert single create method into multi
18952cd 
Taskid: 2703085
Part-of: #80824
Co-authored-by: Victor Feyens <vfe@odoo.com>
robodoo pushed a commit that referenced this pull request Dec 14, 2021
@rco-odoo @tivisse
[FIX] core: create() always inverses fields in the same order
6a12cd6 
This makes the inversion of fields deterministic, as some orderings make
street fields crash in module base_address_extended.

closes #80824

Related: odoo/enterprise#22711
Related: odoo/upgrade#3093
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
@robodoo robodoo closed this Dec 14, 2021
@robodoo robodoo temporarily deployed to merge December 14, 2021 19:59 Inactive
@robodoo robodoo added the 15.2 label Dec 14, 2021
@tivisse tivisse deleted the master-create-yti branch December 15, 2021 07:02
@Feyensv Feyensv mentioned this pull request Jan 27, 2022
Closed
@auroraeosrose auroraeosrose mentioned this pull request Apr 19, 2023
Closed
@auroraeosrose auroraeosrose mentioned this pull request Jul 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Williambraecky Williambraecky Williambraecky left review comments

@amoyaux amoyaux amoyaux left review comments

@tde-banana-odoo tde-banana-odoo tde-banana-odoo left review comments

@rco-odoo rco-odoo rco-odoo left review comments

@Feyensv Feyensv Feyensv left review comments

@xavierbol xavierbol xavierbol left review comments

@IT-Ideas IT-Ideas IT-Ideas left review comments

@awa-odoo awa-odoo awa-odoo left review comments

@kbapt kbapt kbapt requested changes

@qdp-odoo qdp-odoo qdp-odoo approved these changes

Assignees
No one assigned
Labels
15.2 RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet