[FIX] website, *: various fixes related to the website_preview client action #81485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younn-o
force-pushed
the
master-website-in-backend-yol
branch
from
65baa0c
to
7ef8ace
Compare
younn-o
force-pushed
the
master-website-in-backend-yol
branch
4 times, most recently
from
234d429
to
06d5bd0
Compare
|
@younn-o I had to test to be able to sleep :D I pushed 4de4f29 over your branch (you can just remove it and push-force over it) -> just to show that this really work for me: it's the idea with the 2 iframes displaying the same thing... and I don't even need the scroll synchro: my eyes can't see it. I guess it's possible to see that the page "scroll to top before leaving"... but don't see it in my 3min testing. At worst, it should not be difficult to improve on top of that solution to scroll at the same place "beforeunload" or something like that. ... still we double the requests for connected users though, that's not ideal so if there is a better solution, obviously think about it 😉 (maybe something with 2 iframes but instead of loading the same URL twice, you just copy the body DOM of the user-used one "beforeunload" and paste it into the first iframe (supposing the should be the same)? (we can speak about it tomorrow if needed). |
younn-o
commented
Dec 22, 2021
addons/website/static/src/widgets/website_editor/website_editor.js
Outdated
Show resolved
Hide resolved
younn-o
force-pushed
the
master-website-in-backend-yol
branch
2 times, most recently
from
a5d784d
to
198163c
Compare
younn-o
force-pushed
the
master-website-in-backend-yol
branch
4 times, most recently
from
a88dbe7
to
aeb216b
Compare
younn-o
force-pushed
the
master-website-in-backend-yol
branch
5 times, most recently
from
37f5ecc
to
25d05ee
Compare
younn-o
force-pushed
the
master-website-in-backend-yol
branch
6 times, most recently
from
d979e27
to
23619f1
Compare
Before this commit, switching languages from the language dropdown while in edit/translate mode was broken. Now, the click event on this dropdown is listened alongside links with external redirection from the WebsitePreview client action, so that the client action leaves the edit mode while frontend is redirected to the right language. For that, a new leaveEditMode method is added to the website service, which removes the edition classes and unmounts the Editor component. This will further be reviewed in future commits. Also, adding a new language from the language switcher dropdown directly opens the wizard in a dialog on top of the WebsitePreview client action. Follows the merge of the "website in backend" task at [1]. [1]: odoo@31cc10b task-2687506
Before this commit, clicking on the edit button of a slide viewed in fullscreen mode would instantiate the wysiwyg, remove it, exit the fullscreen mode et re-instantiate the wysiwyg. To prevent that, the editor component never starts with the wysiwyg shown by default when mounted. Before that, it checks if it should redirect somewhere in the publicRootReady method (if not, it shows the wysiwyg). Follows the merge of the "website in backend" task at [1]. [1]: odoo@31cc10b task-2687506
*: test_website_modules This commit restores the display of the website loader (the "Building your website" GIF) during the installation of a module from the new content modal, or after completing the configurator flow. Follows the merge of the "website in backend" task at [1]. [1]: odoo@31cc10b task-2687506
Before this commit, the switchTheme option was redirecting the window to the theme_install_kanban_action url. After [1] was merged, the editor is instantiated inside the webclient and the action can now be opened directly from there, without a reload. For that, the request_save event data can include an 'action' parameter, which the WysiwygAdapter will use after leaving debug mode to trigger the action with the action service. [1]: odoo@31cc10b task-2687506
qsm-odoo
force-pushed
the
master-website-in-backend-yol
branch
from
f021867
to
be94eee
Compare
robodoo
pushed a commit
that referenced
this pull request
Jul 8, 2022
This commit adds the PagePropertiesDialogWrapper and AceEditorComponentAdapter as children of the client action, instead of the NavBar. Both of the components are displayed conditionally based on the websiteContext. It allows us to remove the navbar xml patch. With the PagePropertiesDialogWrapper rendered only when needed, it can open directly the appropriate dialog in the onRendered hook, so that we can avoid passing the widget to the parent that would later open it. Follows the merge of the "website in backend" task at [1]. [1]: 31cc10b task-2687506 Part-of: #81485
robodoo
pushed a commit
that referenced
this pull request
Jul 8, 2022
Before this commit, switching languages from the language dropdown while in edit/translate mode was broken. Now, the click event on this dropdown is listened alongside links with external redirection from the WebsitePreview client action, so that the client action leaves the edit mode while frontend is redirected to the right language. For that, a new leaveEditMode method is added to the website service, which removes the edition classes and unmounts the Editor component. This will further be reviewed in future commits. Also, adding a new language from the language switcher dropdown directly opens the wizard in a dialog on top of the WebsitePreview client action. Follows the merge of the "website in backend" task at [1]. [1]: 31cc10b task-2687506 Part-of: #81485
robodoo
pushed a commit
that referenced
this pull request
Jul 8, 2022
Before this commit, clicking on the edit button of a slide viewed in fullscreen mode would instantiate the wysiwyg, remove it, exit the fullscreen mode et re-instantiate the wysiwyg. To prevent that, the editor component never starts with the wysiwyg shown by default when mounted. Before that, it checks if it should redirect somewhere in the publicRootReady method (if not, it shows the wysiwyg). Follows the merge of the "website in backend" task at [1]. [1]: 31cc10b task-2687506 Part-of: #81485
robodoo
pushed a commit
that referenced
this pull request
Jul 8, 2022
*: test_website_modules This commit restores the display of the website loader (the "Building your website" GIF) during the installation of a module from the new content modal, or after completing the configurator flow. Follows the merge of the "website in backend" task at [1]. [1]: 31cc10b task-2687506 Part-of: #81485
robodoo
pushed a commit
that referenced
this pull request
Jul 8, 2022
Before this commit, the switchTheme option was redirecting the window to the theme_install_kanban_action url. After [1] was merged, the editor is instantiated inside the webclient and the action can now be opened directly from there, without a reload. For that, the request_save event data can include an 'action' parameter, which the WysiwygAdapter will use after leaving debug mode to trigger the action with the action service. [1]: 31cc10b task-2687506 closes #81485 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
eres-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jul 19, 2022
This commit adds the PagePropertiesDialogWrapper and AceEditorComponentAdapter as children of the client action, instead of the NavBar. Both of the components are displayed conditionally based on the websiteContext. It allows us to remove the navbar xml patch. With the PagePropertiesDialogWrapper rendered only when needed, it can open directly the appropriate dialog in the onRendered hook, so that we can avoid passing the widget to the parent that would later open it. Follows the merge of the "website in backend" task at [1]. [1]: odoo@31cc10b task-2687506 Part-of: odoo#81485
eres-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jul 19, 2022
Before this commit, switching languages from the language dropdown while in edit/translate mode was broken. Now, the click event on this dropdown is listened alongside links with external redirection from the WebsitePreview client action, so that the client action leaves the edit mode while frontend is redirected to the right language. For that, a new leaveEditMode method is added to the website service, which removes the edition classes and unmounts the Editor component. This will further be reviewed in future commits. Also, adding a new language from the language switcher dropdown directly opens the wizard in a dialog on top of the WebsitePreview client action. Follows the merge of the "website in backend" task at [1]. [1]: odoo@31cc10b task-2687506 Part-of: odoo#81485
eres-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jul 19, 2022
Before this commit, clicking on the edit button of a slide viewed in fullscreen mode would instantiate the wysiwyg, remove it, exit the fullscreen mode et re-instantiate the wysiwyg. To prevent that, the editor component never starts with the wysiwyg shown by default when mounted. Before that, it checks if it should redirect somewhere in the publicRootReady method (if not, it shows the wysiwyg). Follows the merge of the "website in backend" task at [1]. [1]: odoo@31cc10b task-2687506 Part-of: odoo#81485
eres-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jul 19, 2022
*: test_website_modules This commit restores the display of the website loader (the "Building your website" GIF) during the installation of a module from the new content modal, or after completing the configurator flow. Follows the merge of the "website in backend" task at [1]. [1]: odoo@31cc10b task-2687506 Part-of: odoo#81485
eres-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jul 19, 2022
Before this commit, the switchTheme option was redirecting the window to the theme_install_kanban_action url. After [1] was merged, the editor is instantiated inside the webclient and the action can now be opened directly from there, without a reload. For that, the request_save event data can include an 'action' parameter, which the WysiwygAdapter will use after leaving debug mode to trigger the action with the action service. [1]: odoo@31cc10b task-2687506 closes odoo#81485 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-2687506
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr