[IMP] Move closed flag of project task type direcly in project module instead of sale_service

[adrienpeiffer]

Currently, there is a close flag on task type model. This flag is used to define on a type of task if a task in this state is completed or not. But this flag is added by the sale_service module. However, it could be declared in the project module.

[sbidoul]

The closed flag on task type is of general interest in many modules. To get it today, we need to install sale_service which in turns pulls a lot dependencies which are not always desirable.

This PR moves the closed flag to the project module so it becomes more widely available.

Since project is already a dependency of sale_service this change is backward compatible.

👍

[pedrobaeza]

I also agree that this should be moved, but I'm not sure if stable policy allows to reallocate this field in v8. Anyway, for master and if possible for v8 👍

[sbidoul]

This does not change the database structure and the move would be virtually invisible to other addons so this should be ok wrt stable policy.

[rafaelbn]

👍

[rafaelbn]

@adrienpeiffer @sbidoul Odoo answer me. You can close this PR, Odoo will not merge it as:

Hello Rafael,

As stated in our contributing policy, we only accept proposals solving blocking issues in stable releases.

Improvements are not accepted in stable releases, such as 8.0.

For more information, please read:
https://github.com/odoo/odoo/wiki/Contributing#what-does-stable-mean

Do you think we can do this proposal to OCB? or independent module?

[sbidoul]

@rafaelbn I'm preparing a module project_stage_closed that I'll submit to OCA/project.

[sbidoul]

project_stage_closed is merged in OCA/project. This PR is now unncessary. @adrienpeiffer can you close it?

[adrienpeiffer]

Yes !