[FW][IMP] l10n_au: tax report headings #83334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @richard-willdooit, @william-andre cherrypicking of pull request #79138 failed. stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
robodoo
added
conflict
|
@william-andre I'm pretty sure I'm not in a position to do something here? |
No, I will write a script to do the forward port automatically |
- Remove "subtotal" amounts from headings. - Pull GST only and G20 in under purchasing header. - Remove tag from comparison heading, as it should have no links to audit. - Add summary section, to make G9 and G20 transfer to 1A / 1B as per ATO suggested formatting, and to make those figures easier to find on the report. X-original-commit: f3224a2
william-andre
force-pushed
the
saas-15.1-13.0-l10n_au-tax-headings-vz9h-fw
branch
from
ecb93bf
to
7ff2849
Compare
|
3 hours to write a simple script... https://gist.github.com/william-andre/5e4179d078b7ed0a48044ee8e0e8c777 @robodoo r+ |
C3POdoo
requested review from
a team and
lordkrandel
and removed request for
a team
robodoo
pushed a commit
that referenced
this pull request
Jan 25, 2022
- Remove "subtotal" amounts from headings. - Pull GST only and G20 in under purchasing header. - Remove tag from comparison heading, as it should have no links to audit. - Add summary section, to make G9 and G20 transfer to 1A / 1B as per ATO suggested formatting, and to make those figures easier to find on the report. closes #83334 X-original-commit: f3224a2 Signed-off-by: William André (wan) <wan@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide consistent formatting of totals - amounts owed to the ATO and
amounts owed by the ATO are now formatted the same.
Also, the titles are NOT subtotals of the rows below, leading to
misleading sales / purchase totals (which are not transferred to
BAS in any case).
Description of the issue/feature this PR addresses:
Inconsistent formatting of BAS Tax Report Headings / Totals
Current behavior before PR:
Headings had meaningless unreportable subtotal figures
Total lines were formatted inconsistently
Desired behavior after PR is merged:
Remove unneeded figures and standardise 2 subtotals
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #83267
Forward-Port-Of: #79138