[FIX] web: fix tooling failing to run due to bash-specific syntax #86888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
robodoo delegate=SimonGenin |
|
Thanks @sdegueldre |
SimonGenin
reviewed
Mar 22, 2022
sdegueldre
force-pushed
the
15.0-web-tooling-precommit-crash-fix-sad
branch
from
c03ebdc
to
33baf18
Compare
In odoo#86163 we added a check on the branch name to avoid running the tooling on stable branches, however this check used bash-specific syntax. While the hashbang in the pre-commit hook specifies that the hook should be run using bash, we were using the npm module "husky" to manage git hooks, which would ignore this hashbang and always run the hook using sh, causing the hook to fail in all cases. After some consideration, we have decided to stop using husky, as its main purpose is to make hook management easier in npm-based projects. Since we already need a script to enable the tooling, we can do essentially the same thing that husky is doing but with more control over the process with no drawbacks.
SimonGenin
force-pushed
the
15.0-web-tooling-precommit-crash-fix-sad
branch
from
33baf18
to
2b30a75
Compare
|
@robodoo r+ |
3 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #86163 we added a check on the branch name to avoid running the
tooling on stable branches, however this check used bash-specific
syntax. While the hashbang in the pre-commit hook specifies that the
hook should be run using bash, we were using the npm module "husky" to
manage git hooks, which would ignore this hashbang and always run the
hook using sh, causing the hook to fail in all cases.
After some consideration, we have decided to stop using husky, as its
main purpose is to make hook management easier in npm-based projects.
Since we already need a script to enable the tooling, we can do
essentially the same thing that husky is doing but with more control
over the process with no drawbacks.