[FIX] point_of_sale: fix traceback when fast click validate #89063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinengels
force-pushed
the
15.0-opw-2813512-double_clicking_validate-roen
branch
7 times, most recently
from
a20c8fa
to
3a63c10
Compare
|
I would prefer having a state variable in the component that will serve a lock, such that if it's true, no need to execute the method. Practically similar to your solution but more principled (at least in my opinion). Also, I think you changed the wrong |
robinengels
force-pushed
the
15.0-opw-2813512-double_clicking_validate-roen
branch
2 times, most recently
from
69a52a8
to
56322e3
Compare
|
@caburj this should be better |
caburj
reviewed
May 9, 2022
addons/point_of_sale/static/src/js/Screens/PaymentScreen/PaymentScreen.js
Outdated
Show resolved
Hide resolved
robinengels
force-pushed
the
15.0-opw-2813512-double_clicking_validate-roen
branch
2 times, most recently
from
d412a00
to
bb85533
Compare
Current behavior: When clicking multiple times on the validate button in PoS a traceback appears. When creating a customer from the PoS, if you click mutliple times on the create button the customer would be created multiple times in the Db. Steps to reproduce issue 1: - To reproduce you need a slow internet connection, you can do that in the developper menu of chrome (F12) and in the network tab select 'slow 3G' instead of 'no throttling' - Go in a PoS session, make an order - Go in the payment screen - Press validate multiple times. - A traceback appears Steps to reproduce issue 2: - Go in the customer selection screen - Go in the create customer screen - Enter a name, and click multiple times on the create button - If you check customer list the new customer should appear multiple times opw-2813512
robinengels
force-pushed
the
15.0-opw-2813512-double_clicking_validate-roen
branch
from
bb85533
to
8d7a3ef
Compare
robinengels
added a commit
to odoo-dev/odoo
that referenced
this pull request
May 16, 2022
partial backport of : odoo#89063 opw-2813512
caburj
approved these changes
May 16, 2022
|
@robodoo delegate+ |
|
@robodoo r+ |
5 similar comments
1 similar comment
odooaktiv
pushed a commit
to odooaktiv/odoo
that referenced
this pull request
Jun 13, 2022
partial backport of : odoo#89063 opw-2813512 closes odoo#91469 Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
1 similar comment
This was referenced Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior:
When clicking multiple times on the validate button in PoS
a traceback appears.
When creating a customer from the PoS, if you click mutliple times
on the create button the customer would be created multiple times
in the Db.
Steps to reproduce issue 1:
can do that in the developper menu of chrome (F12) and
in the network tab select 'slow 3G' instead of 'no throttling'
Steps to reproduce issue 2:
multiple times
opw-2813512
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr