[Fix] change_volume_dimension_unit_to_inch #92478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angv-odoo
force-pushed
the
15.0-add_new_volume_dimension_units-angv
branch
from
166ff58
to
ce37f6e
Compare
Due to the fact that the only avaliable volume unit in odoo 15 is feet for imperial system, Users can not create packages that have less then 1 foot dimension. This commit changes feet to inches, so the lowest value for package can be 1 inch^3 instead of 1 foot^3
angv-odoo
force-pushed
the
15.0-add_new_volume_dimension_units-angv
branch
from
ce37f6e
to
3bc4d20
Compare
|
Ok but I would avoid in stable. I agree with the change if we stuck to delivery but we don't know if some other people used this field for other purpose (customization). If there is a lot of ticket/issues linked to it, then we could do it Also I notice that the package size is not converted from cm to inch in easypost, usps (less important since it's limited from USA to USA) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that the only avaliable volume unit in odoo 15 is feet for imperial system,
Users can not create packages that have less then 1 foot dimension. This commit changes feet
to inches, so the lowest volume for package can be 1 inch^3 instead of 1 foot^3
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr