[FIX] mrp: prevent byproduct missing record error #92728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kado-odoo
force-pushed
the
15.0-mrp-by-products-user-error-fix-kado
branch
from
328743e
to
5fb3826
Compare
kado-odoo
changed the title
kado-odoo
force-pushed
the
15.0-mrp-by-products-user-error-fix-kado
branch
2 times, most recently
from
f02d44f
to
12a62be
Compare
ticodoo
reviewed
Jun 22, 2022
There was a problem hiding this comment.
Fix seems fine except for my one comment and ideally you should add a test as well since byproducts don't have many tests and they seem to be quite buggy.
Also your commit message should be improved:
- There is no need to write what code change did since it is already in your code change.
- It would be better to say your fix is a modified version of the similar bugfix: c1768d0
- You don't really explain why the issue was occurring so its hard to understand your solution (see the similar bugfix for its explanation of why the issue is occurring)
- It should be "missing record error" instead of "missing error"
- rename your commit to something more specific and remove 2nd reference to mrp since its already there:
[FIX] mrp: prevent byproduct missing record error
addons/mrp/models/mrp_production.py
Outdated
Comment on lines
728
to
729
| if 'move_byproduct_ids' in vals and 'move_finished_ids' not in vals: | ||
| vals['move_finished_ids'] = vals.get('move_finished_ids', []) + vals['move_byproduct_ids'] |
There was a problem hiding this comment.
If condition looks for 'move_finished_ids' not in vals, then won't vals.get('move_finished_ids', []) always be []?
kado-odoo
force-pushed
the
15.0-mrp-by-products-user-error-fix-kado
branch
2 times, most recently
from
4a0792a
to
561484c
Compare
kado-odoo
changed the title
|
@ticodoo |
|
Hello, I believe you can combine your new test with Also:
|
Before this commit, there was a bug with MO by-product moves:
- With a newly created MO, confirm MO and after manually add `Produced`
quantity in By-Products and change quantity producing in MO and save the
record then it raises the missing record error.
same issues was fixed here odoo@c1768d0
but forgot to fix same in write method.
so this commit is fix same but in write method
TaskID - 2799848
kado-odoo
force-pushed
the
15.0-mrp-by-products-user-error-fix-kado
branch
from
561484c
to
41f4b0c
Compare
|
@ticodoo |
|
LGTM, thanks for your work! @robodoo r+ |
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, there was a bug with MO by-product moves:
same issues was fixed here c1768d0
but forgot to fix same in write method.
so this commit is fix same but in write method
TaskID - 2799848
PR - #92728