[FW][FIX] profiler: make profiler work with freezegun #95049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When freezegun is used, the profiler and sql_db time are freezed, Making the profile and sql perf counters invalids. A possible solution would be to black list some modules in freezegun but this doens't look possible in the pinned version (0.3.x). Saving the builtin time.time is not enough, it looks like freezegun will find all occurences and replace them. We need to get the __call__ instead. X-original-commit: 32213fb
|
This PR targets saas-15.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
Ping @Xavier-Do, @d-fence
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
|
Staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/build/17090503) |
|
@robodoo retry |
|
Staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/build/17091058) |
|
Unlucky? @robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
Jul 1, 2022
When freezegun is used, the profiler and sql_db time are freezed, Making the profile and sql perf counters invalids. A possible solution would be to black list some modules in freezegun but this doens't look possible in the pinned version (0.3.x). Saving the builtin time.time is not enough, it looks like freezegun will find all occurences and replace them. We need to get the __call__ instead. closes #95049 X-original-commit: 32213fb Signed-off-by: Christophe Monniez (moc) <moc@odoo.com> Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When freezegun is used, the profiler and sql_db time are freezed,
Making the profile and sql perf counters invalids.
A possible solution would be to black list some modules in freezegun but
this doens't look possible in the pinned version (0.3.x).
Saving the builtin time.time is not enough, it looks like freezegun will
find all occurences and replace them.
We need to get the call instead.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #94998