[FW][FIX] hr_expense: remove taxes_id from product view #95088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduction: 1. Install Expense in V15 2. Go to Expense->Configuration->Expense Products 3. Create a new product, after selecting a few Customer Taxes, click save, the selected taxes are not shown on the saved page Reason: The taxes_id is defined twice. One is in the hr_view, another is in the product_view of the module sale_expense. This causes the taxes are not shown on the saved page after choosing and saving the customer taxes. But when you Edit the product and choose another customer tax, the chosen taxes appear again. Fix: This fix changes the inherited view in sale_expense, to make sure the selected customer taxes are not erased in the view. It's a safer fix as it avoids potentially broken customization opw-2852894 related change: 26a5653#diff-35ce298bc166ce5f8a1fb1a73ae7f7c7730e12925d518dedfab92ce63e6bb83dL527-L529 X-original-commit: 5baee4a
|
Ping @Jinjiu96, @nle-odoo To merge the full chain, say
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Jul 1, 2022
Reproduction: 1. Install Expense in V15 2. Go to Expense->Configuration->Expense Products 3. Create a new product, after selecting a few Customer Taxes, click save, the selected taxes are not shown on the saved page Reason: The taxes_id is defined twice. One is in the hr_view, another is in the product_view of the module sale_expense. This causes the taxes are not shown on the saved page after choosing and saving the customer taxes. But when you Edit the product and choose another customer tax, the chosen taxes appear again. Fix: This fix changes the inherited view in sale_expense, to make sure the selected customer taxes are not erased in the view. It's a safer fix as it avoids potentially broken customization opw-2852894 related change: odoo-dev@26a5653#diff-35ce298bc166ce5f8a1fb1a73ae7f7c7730e12925d518dedfab92ce63e6bb83dL527-L529 closes #95088 X-original-commit: 5baee4a Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com> Signed-off-by: Liu Jinjiu (jili) <jili@odoo.com>
fw-bot
deleted the
saas-15.1-15.0-opw-2852894-hr_expense-remove_redundant_taxes_id-jili-8XCz-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction:
save, the selected taxes are not shown on the saved page
Reason: The taxes_id is defined twice. One is in the hr_view, another is
in the product_view of the module sale_expense. This causes the taxes
are not shown on the saved page after choosing and saving the customer
taxes. But when you Edit the product and choose another customer tax,
the chosen taxes appear again.
Fix: This fix changes the inherited view in sale_expense, to make sure
the selected customer taxes are not erased in the view. It's a safer fix
as it avoids potentially broken customization
opw-2852894
related change: odoo-dev@26a5653#diff-35ce298bc166ce5f8a1fb1a73ae7f7c7730e12925d518dedfab92ce63e6bb83dL527-L529
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #94671