[FW][IMP] l10n_es_edi_sii: clearer missing element TipoDesglose error #95122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @alt-odoo, @FlorianGilbert cherrypicking of pull request #94688 failed. stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
robodoo
added
conflict
When sending an invoice to the SII edi, the field TipoDesglose is required. In case we have a foreign customer outside of Spain, we are filtering the taxes information based on the tax scope (services or goods). In case the tax scope is not filled in, TipoDesglose is not provided and this will cause the request to fail, with no clear reason for the user. We should add an UserError message to make it clear enough so the user can fix it himself. X-original-commit: 03d833e
alt-odoo
force-pushed
the
saas-15.1-14.0-clearer-missing-element-sii-error-alt-8QIH-fw
branch
from
83827d3
to
3298ef7
Compare
|
@robodoo r+ |
|
Staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/build/17101281) |
|
@robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
Jul 2, 2022
When sending an invoice to the SII edi, the field TipoDesglose is required. In case we have a foreign customer outside of Spain, we are filtering the taxes information based on the tax scope (services or goods). In case the tax scope is not filled in, TipoDesglose is not provided and this will cause the request to fail, with no clear reason for the user. We should add an UserError message to make it clear enough so the user can fix it himself. closes #95122 X-original-commit: 03d833e Signed-off-by: Florian Gilbert (flg) <flg@odoo.com> Signed-off-by: Alex Thuyls (alt) <alt@odoo.com>
This was referenced Jul 2, 2022
fw-bot
deleted the
saas-15.1-14.0-clearer-missing-element-sii-error-alt-8QIH-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending an invoice to the SII edi, the field TipoDesglose is
required. In case we have a foreign customer outside of Spain, we are
filtering the taxes information based on the tax scope (services or
goods). In case the tax scope is not filled in, TipoDesglose is not
provided and this will cause the request to fail, with no clear reason
for the user. We should add an UserError message to make it clear enough
so the user can fix it himself.
Description of the issue/feature this PR addresses:
opw-2886985
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #94688