Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] account: Prevent deletion of tax lines #95151

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Jul 1, 2022

Improvement of the current fixes:
ac3cf2e
feb4e83

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #95129
Forward-Port-Of: #94734

Improvement of the current fixes:
odoo@ac3cf2e
odoo@feb4e83

- A tax line is linked to a tax repartition line. If you suppose a tax with 2 repartition lines then, removing one tax line should recompute the tax line.
- There are multiple taxes configuration leading to a tax line with a zero amount. For example, python tax, fixed tax with quantity = 0, a tax with a tiny amount...etc

X-original-commit: 3b0e52c
@robodoo
Copy link
Contributor

robodoo commented Jul 1, 2022

@fw-bot
Copy link
Contributor Author

fw-bot commented Jul 1, 2022

This PR targets saas-15.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Jul 1, 2022
@C3POdoo C3POdoo added the RD research & development, internal work label Jul 1, 2022
robodoo pushed a commit that referenced this pull request Jul 2, 2022
Improvement of the current fixes:
ac3cf2e
feb4e83

- A tax line is linked to a tax repartition line. If you suppose a tax with 2 repartition lines then, removing one tax line should recompute the tax line.
- There are multiple taxes configuration leading to a tax line with a zero amount. For example, python tax, fixed tax with quantity = 0, a tax with a tiny amount...etc

closes #95151

X-original-commit: 3b0e52c
Signed-off-by: William André (wan) <wan@odoo.com>
@robodoo robodoo closed this Jul 2, 2022
@robodoo robodoo temporarily deployed to merge July 2, 2022 07:42 Inactive
@fw-bot fw-bot deleted the saas-15.1-13.0-prevent-tax-removal-las-Zhys-fw branch July 16, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants