[ADD] l10n_latam_check: new module #96074

zaoral · 2022-07-14T23:02:15Z

latam task 445
related to opw-2528442

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

robodoo · 2022-07-14T23:02:27Z

addons/l10n_latam_check/i18n/es.po

addons/l10n_latam_check/models/account_payment.py

vbe-odoo · 2022-08-05T18:27:10Z

@jjscarafia @jco-odoo I've tested the last changes and LGTM. All sequences are working properly when changing checkbooks, and all sequences are working as expected (even when changing them).

Ready for additional final tech review.
cc' @fvz-odoo @ren-odoo

addons/l10n_latam_check/models/account_journal.py

addons/l10n_latam_check/models/account_payment.py

vbe-odoo · 2022-09-06T16:08:41Z

Hello, @william-andre can you help me with the review of this PR, as this is a high-priority PR for AR.
If you can help us with your review this week, next week we can check the final details with @jco-odoo (he already did his last tech review) upon his return, and merge it.
Thanks!
cc' @ren-odoo @fvz-odoo

william-andre · 2022-09-06T17:42:34Z

I will have a look at it after the freeze, I have quite a few of important PRs to review before this one as they are blocking for it.

vbe-odoo · 2022-09-06T17:54:43Z

@fhe-odoo as we discussed, we are still waiting for the last technical review and approval, but it will be reviewed after the freeze is done.

Still, this is a high-priority task from our end, so hopefully, it won't take too much time after the freeze is done.
Thanks!
cc' @ren-odoo @fvz-odoo @jco-odoo

vbe-odoo · 2022-09-26T18:15:35Z

Hello, @william-andre @jco-odoo any luck with this PR review?
Thanks!
cc' @fhe-odoo @ren-odoo @fvz-odoo @jjscarafia @zaoral

william-andre

I think I don't get the point of most of this.
Regarding third party checks, why aren't we going for something that looks like a simple approach (but naive?):

create a new model for checks not cashed in yet
create an delete (or change the status of) these records when you receive/give them when making a payment record

I think that a lot of the complicated things/tricks from the implementation will simply disappear with that approach.

addons/l10n_latam_check/models/account_journal.py

addons/l10n_latam_check/models/account_payment.py

addons/l10n_latam_check/__manifest__.py

addons/l10n_latam_check/wizards/account_payment_register.py

vbe-odoo · 2022-10-26T21:54:02Z

I think I don't get the point of most of this. Regarding third party checks, why aren't we going for something that looks like a simple approach (but naive?):

create a new model for checks not cashed in yet

create an delete (or change the status of) these records when you receive/give them when making a payment record

I think that a lot of the complicated things/tricks from the implementation will simply disappear with that approach.

Just to give you some answers/ideas on the "why" of these 2 points (why we didn't use/create a check object, as that was one of the ideas at the beginning):

We tried to avoid a new Object as much as possible
The accounting team didn't want/suggested not to split the account.move.lines in the account.move coming from the payment in order to do the bank reconciliation per line/per check (as every check will have its own number). Because then on the bank statement, every check will be 1 line to be reconciled.

So based on the feedback on that point, from a technical perspective (no new object) and from a functional/accounting perspective (better not to split the journal items) is that we decided to move forward with the current approach of using the payment as a check (1 payment = 1 check).

cc' @william-andre @jco-odoo @jjscarafia @zaoral @fvz-odoo

addons/l10n_latam_check/__manifest__.py

addons/l10n_latam_check/models/account_payment.py

addons/l10n_latam_check/models/account_journal.py

jjscarafia · 2022-12-02T10:23:32Z

@william-andre @jco-odoo
Last comments where attended. Please let us know if we should make any other change.

Once you confirm it's ok we make a final squash.

Can you trigger install and test of this module on runbot? Because it's not installed automatically due to be "l10n_x"

cc @zaoral @vbe-odoo

william-andre

Can you trigger install and test of this module on runbot? Because it's not installed automatically due to be "l10n_x"

Done!

zaoral · 2022-12-02T11:09:53Z

@william-andre
All the commits has been squashed

Xavier-Do · 2022-12-02T12:15:49Z

Upgrade exception #168 added.

Waiting the forward-port of this pr, the exception will be applied on all builds, and create an inconsistent state for migrations.
Please forward port this asap up to master without change. Exception should be forward-ported before the end of the week.

If you need to apply any change before it reaches master, please notify runbot team.

Details:

field:account.payment.show_check_number

cc @KangOl @nseinlet

jco-odoo · 2022-12-02T12:27:35Z

@zaoral @jjscarafia A test is failing here: https://runbot.odoo.com/runbot/batch/910902/build/21547931

addons/l10n_latam_check/tests/test_own_checks.py

In order to make this modules to also match new module l10n_latam_check. * refactory of some methods to make it more heritable * check number now is showed only when is defined and is related to check_printing payment method.

zaoral · 2022-12-02T13:12:21Z

Hi @jco-odoo

About the comment made by @Xavier-Do
The error is related to the new field show_check_number we are adding in the first commit of this PR. As far as I remember we already have that problem in the past. That was the reason we change the PR to master. In this case what we need to do to solve it?

jco-odoo · 2022-12-02T13:13:30Z

@zaoral It was solved by @Xavier-Do allowing the exception.

addons/l10n_latam_check/tests/test_own_checks.py

New features to manage checks and managed them Odoo in latam countries where they are widely use. Own Checks Management --------------------- Extends 'Check Printing Base' module to manage own checks with more features: * allow using own checks that are not printed but filled manually by the user * allow to use deferred or electronic checks * printing is disabled * check number is set manually by the user * add an optional "Check Cash-In Date" for post-dated checks (deferred payments) * add a menu to track own checks Third Party Checks Management ----------------------------- Add new "Third party check Management" feature. There are 2 main Payment Methods additions: * New Third Party Checks: * allow the user create a check on the fly from a payment * create a third party check from a customer payment * Existing Third party check: * allow the user to reuse a Third party check already created * pay a vendor bill using an existing Third party check * move an existing checks between journals (i.e. move to Rejected) * Send/Receive again a check already used in a Vendor Bill/Customer INV * allow the user to do mass check transfers

zaoral · 2022-12-02T16:34:08Z

Hi everyone!

Good news, PR is green, including l10n staging tests!
We think is ready fore merge @jco-odoo

william-andre · 2022-12-02T16:38:11Z

@robodoo r+

robodoo · 2022-12-02T17:00:43Z

@zaoral @william-andre because this PR has multiple commits, I need to know how to merge it:

merge to merge directly, using the PR as merge commit message
rebase-merge to rebase and merge, using the PR as merge commit message
rebase-ff to rebase and fast-forward

zaoral · 2022-12-02T17:08:06Z

ping @william-andre

jco-odoo · 2022-12-02T17:15:02Z

@robodoo rebase-ff

robodoo · 2022-12-02T17:16:07Z

Merge method set to rebase and fast-forward.

In order to make this modules to also match new module l10n_latam_check. * refactory of some methods to make it more heritable * check number now is showed only when is defined and is related to check_printing payment method. Part-of: #96074

In order to make this modules to also match new module l10n_latam_check. * refactory of some methods to make it more heritable * check number now is showed only when is defined and is related to check_printing payment method. Part-of: odoo#96074

New features to manage checks and managed them Odoo in latam countries where they are widely use. Own Checks Management --------------------- Extends 'Check Printing Base' module to manage own checks with more features: * allow using own checks that are not printed but filled manually by the user * allow to use deferred or electronic checks * printing is disabled * check number is set manually by the user * add an optional "Check Cash-In Date" for post-dated checks (deferred payments) * add a menu to track own checks Third Party Checks Management ----------------------------- Add new "Third party check Management" feature. There are 2 main Payment Methods additions: * New Third Party Checks: * allow the user create a check on the fly from a payment * create a third party check from a customer payment * Existing Third party check: * allow the user to reuse a Third party check already created * pay a vendor bill using an existing Third party check * move an existing checks between journals (i.e. move to Rejected) * Send/Receive again a check already used in a Vendor Bill/Customer INV * allow the user to do mass check transfers closes odoo#96074 Signed-off-by: William André (wan) <wan@odoo.com>

zaoral mentioned this pull request Jul 19, 2022

[WIP][15.0][ADD] l10n_latam_check #83542

Closed

vbe-odoo reviewed Aug 1, 2022

View reviewed changes

addons/l10n_latam_check/i18n/es.po Outdated Show resolved Hide resolved

vbe-odoo reviewed Aug 2, 2022

View reviewed changes

addons/l10n_latam_check/models/account_payment.py Outdated Show resolved Hide resolved

jjscarafia force-pushed the master-latam-445-kz branch from 29e13c8 to b9a618b Compare August 4, 2022 16:38

jjscarafia force-pushed the master-latam-445-kz branch from b9a618b to dcc1c0b Compare August 10, 2022 18:19

jco-odoo reviewed Aug 11, 2022

View reviewed changes

vbe-odoo reviewed Aug 18, 2022

View reviewed changes

addons/l10n_latam_check/models/account_payment.py Show resolved Hide resolved

jjscarafia force-pushed the master-latam-445-kz branch 2 times, most recently from 10fe2e0 to 42abc21 Compare August 26, 2022 10:15

jjscarafia force-pushed the master-latam-445-kz branch from 42abc21 to bb7f660 Compare September 15, 2022 18:04

zaoral force-pushed the master-latam-445-kz branch from bb7f660 to bda0109 Compare October 25, 2022 18:45

zaoral changed the base branch from master to 16.0 October 25, 2022 20:16

zaoral force-pushed the master-latam-445-kz branch from bda0109 to 35b9699 Compare October 25, 2022 20:16

C3POdoo requested review from a team and Levizar and removed request for a team October 25, 2022 20:21

william-andre reviewed Oct 26, 2022

View reviewed changes

zaoral force-pushed the master-latam-445-kz branch from a318d4a to 3939854 Compare November 10, 2022 15:26

zaoral mentioned this pull request Nov 11, 2022

[REM] l10n_latam_check: Now we use official module ingadhoc/account-payment#315

Closed

Levizar removed their request for review November 14, 2022 10:08

jco-odoo reviewed Nov 17, 2022

View reviewed changes

addons/l10n_latam_check/__manifest__.py Outdated Show resolved Hide resolved

addons/l10n_latam_check/models/account_payment.py Outdated Show resolved Hide resolved

addons/l10n_latam_check/models/account_journal.py Outdated Show resolved Hide resolved

zaoral force-pushed the master-latam-445-kz branch 2 times, most recently from 180f4a1 to 8543eda Compare November 18, 2022 16:32

william-andre approved these changes Dec 2, 2022

View reviewed changes

zaoral force-pushed the master-latam-445-kz branch from a1db163 to 68a47ef Compare December 2, 2022 11:02

jco-odoo reviewed Dec 2, 2022

View reviewed changes

addons/l10n_latam_check/tests/test_own_checks.py Outdated Show resolved Hide resolved

[IMP] account, account_check_printing: latam adapt

3797be6

In order to make this modules to also match new module l10n_latam_check. * refactory of some methods to make it more heritable * check number now is showed only when is defined and is related to check_printing payment method.

zaoral force-pushed the master-latam-445-kz branch from 68a47ef to d90960c Compare December 2, 2022 13:03

jco-odoo reviewed Dec 2, 2022

View reviewed changes

addons/l10n_latam_check/tests/test_own_checks.py Outdated Show resolved Hide resolved

zaoral force-pushed the master-latam-445-kz branch from d90960c to 9f28c9f Compare December 2, 2022 14:14

robodoo closed this in cbec68b Dec 2, 2022

robodoo temporarily deployed to merge December 2, 2022 22:39 Inactive

fw-bot mentioned this pull request Dec 2, 2022

[FW][ADD] l10n_latam_check: new module #107163

Closed

zaoral deleted the master-latam-445-kz branch December 5, 2022 18:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] l10n_latam_check: new module #96074

[ADD] l10n_latam_check: new module #96074

zaoral commented Jul 14, 2022 •

edited

robodoo commented Jul 14, 2022

vbe-odoo commented Aug 5, 2022 •

edited

vbe-odoo commented Sep 6, 2022

william-andre commented Sep 6, 2022

vbe-odoo commented Sep 6, 2022

vbe-odoo commented Sep 26, 2022

william-andre left a comment

vbe-odoo commented Oct 26, 2022 •

edited

jjscarafia commented Dec 2, 2022 •

edited

william-andre left a comment

zaoral commented Dec 2, 2022

Xavier-Do commented Dec 2, 2022

jco-odoo commented Dec 2, 2022

zaoral commented Dec 2, 2022

jco-odoo commented Dec 2, 2022

zaoral commented Dec 2, 2022

william-andre commented Dec 2, 2022

robodoo commented Dec 2, 2022

zaoral commented Dec 2, 2022

jco-odoo commented Dec 2, 2022

robodoo commented Dec 2, 2022

[ADD] l10n_latam_check: new module #96074

[ADD] l10n_latam_check: new module #96074

Conversation

zaoral commented Jul 14, 2022 • edited

robodoo commented Jul 14, 2022

vbe-odoo commented Aug 5, 2022 • edited

vbe-odoo commented Sep 6, 2022

william-andre commented Sep 6, 2022

vbe-odoo commented Sep 6, 2022

vbe-odoo commented Sep 26, 2022

william-andre left a comment

Choose a reason for hiding this comment

vbe-odoo commented Oct 26, 2022 • edited

jjscarafia commented Dec 2, 2022 • edited

william-andre left a comment

Choose a reason for hiding this comment

zaoral commented Dec 2, 2022

Xavier-Do commented Dec 2, 2022

jco-odoo commented Dec 2, 2022

zaoral commented Dec 2, 2022

jco-odoo commented Dec 2, 2022

zaoral commented Dec 2, 2022

william-andre commented Dec 2, 2022

robodoo commented Dec 2, 2022

zaoral commented Dec 2, 2022

jco-odoo commented Dec 2, 2022

robodoo commented Dec 2, 2022

zaoral commented Jul 14, 2022 •

edited

vbe-odoo commented Aug 5, 2022 •

edited

vbe-odoo commented Oct 26, 2022 •

edited

jjscarafia commented Dec 2, 2022 •

edited